public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] ld: Set default subsystem for arm-pe to IMAGE_SUBSYSTEM_WINDOWS_GUI
@ 2023-01-23 20:30 Mark Harmstone
  0 siblings, 0 replies; only message in thread
From: Mark Harmstone @ 2023-01-23 20:30 UTC (permalink / raw)
  To: bfd-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cec13966ba4f7c85f527a6310e1b07ee956d08f3

commit cec13966ba4f7c85f527a6310e1b07ee956d08f3
Author: Mark Harmstone <mark@harmstone.com>
Date:   Sun Jan 22 23:45:03 2023 +0000

    ld: Set default subsystem for arm-pe to IMAGE_SUBSYSTEM_WINDOWS_GUI
    
    This fixes the test failures introduced by 87a5cf5c, by changing the
    default subsystem for arm-pe from 9 (IMAGE_SUBSYSTEM_WINDOWS_CE_GUI) to
    2 (IMAGE_SUBSYSTEM_WINDOWS_GUI), which matches what happens with other
    PE targets.
    
    As far as I can tell there's no working modern Windows CE toolchain
    knocking about anyway, so this change shouldn't inconvenience anyone.

Diff:
---
 ld/emultempl/pe.em | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/ld/emultempl/pe.em b/ld/emultempl/pe.em
index 0413d07d6c3..0354c560fc7 100644
--- a/ld/emultempl/pe.em
+++ b/ld/emultempl/pe.em
@@ -138,7 +138,10 @@ fragment <<EOF
 #undef PE_DEF_FILE_ALIGNMENT
 #define NT_EXE_IMAGE_BASE		0x00010000
 
-#if defined(TARGET_IS_armpe) || defined(TARGET_IS_arm_wince_pe)
+#if defined(TARGET_IS_armpe)
+#define PE_DEF_SECTION_ALIGNMENT	0x00001000
+#define	PE_DEF_SUBSYSTEM		2
+#elif defined(TARGET_IS_arm_wince_pe)
 #define PE_DEF_SECTION_ALIGNMENT	0x00001000
 #define	PE_DEF_SUBSYSTEM		9
 #else

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-23 20:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 20:30 [binutils-gdb] ld: Set default subsystem for arm-pe to IMAGE_SUBSYSTEM_WINDOWS_GUI Mark Harmstone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).