From: Alan Modra <amodra@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] Call bfd_close_all_done in output_file_close
Date: Fri, 27 Jan 2023 07:02:53 +0000 (GMT) [thread overview]
Message-ID: <20230127070253.F160A3858433@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3e7cde4dca8c63b8091597bd7800f0f71e822395
commit 3e7cde4dca8c63b8091597bd7800f0f71e822395
Author: Alan Modra <amodra@gmail.com>
Date: Fri Jan 27 12:31:27 2023 +1030
Call bfd_close_all_done in output_file_close
bfd_cache_close_all is good for closing file descriptors, but doesn't
do the cleanup of bfd memory as in bfd_close_all_done.
PR 13056
* output-file.c (output_file_close): Call bfd_close_all_done,
not bfd_cache_close_all.
Diff:
---
gas/output-file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gas/output-file.c b/gas/output-file.c
index 4c97e8f1a9b..88f40116513 100644
--- a/gas/output-file.c
+++ b/gas/output-file.c
@@ -96,7 +96,7 @@ output_file_close (void)
/* Close the bfd. */
if (!flag_always_generate_output && had_errors ())
- res = bfd_cache_close_all ();
+ res = bfd_close_all_done (obfd);
else
res = bfd_close (obfd);
now_seg = NULL;
reply other threads:[~2023-01-27 7:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127070253.F160A3858433@sourceware.org \
--to=amodra@sourceware.org \
--cc=bfd-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).