public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] Memory leak in bfd_init_section_compress_status
@ 2023-02-08 23:15 Alan Modra
  0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2023-02-08 23:15 UTC (permalink / raw)
  To: bfd-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=389903128ac5686dc83efd121339158465614d67

commit 389903128ac5686dc83efd121339158465614d67
Author: Alan Modra <amodra@gmail.com>
Date:   Wed Feb 8 23:49:46 2023 +1030

    Memory leak in bfd_init_section_compress_status
    
            * compress.c (bfd_init_section_compress_status): Free
            uncompressed_buffer on error return.

Diff:
---
 bfd/compress.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/bfd/compress.c b/bfd/compress.c
index 2cf8a6c28c9..2a402c3f65c 100644
--- a/bfd/compress.c
+++ b/bfd/compress.c
@@ -1083,7 +1083,10 @@ bfd_init_section_compress_status (bfd *abfd, sec_ptr sec)
 
   if (!bfd_get_section_contents (abfd, sec, uncompressed_buffer,
 				 0, uncompressed_size))
-    return false;
+    {
+      free (uncompressed_buffer);
+      return false;
+    }
 
   sec->contents = uncompressed_buffer;
   if (bfd_compress_section_contents (abfd, sec) == 0)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-08 23:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 23:15 [binutils-gdb] Memory leak in bfd_init_section_compress_status Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).