From: Tom Tromey <tromey@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] Hoist the SECTION comment in opncls.c
Date: Mon, 20 Feb 2023 21:36:01 +0000 (GMT) [thread overview]
Message-ID: <20230220213601.9EE7C3858D39@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=03a7c6eb51811e7c0b0fa21fbdf2b3434986ba64
commit 03a7c6eb51811e7c0b0fa21fbdf2b3434986ba64
Author: Tom Tromey <tom@tromey.com>
Date: Fri Feb 17 12:12:11 2023 -0700
Hoist the SECTION comment in opncls.c
The opening and closing node in BFD starts:
File: bfd.info, [...]
/* Set to N to open the next N BFDs using an alternate id space. */
extern unsigned int bfd_use_reserved_id;
2.13 Opening and closing BFDs
=============================
That is, there's a stray C comment and declaration before any other
text or subsections.
This occurs because the code fragment for bfd_use_reserved_id comes
before the SECTION comment. Hoisting it makes this a little nicer.
2023-02-17 Tom Tromey <tom@tromey.com>
* opncls.c: Hoist the SECTION comment.
Diff:
---
bfd/ChangeLog | 4 ++++
bfd/opncls.c | 16 ++++++++--------
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index a974a5c6716..fac38b8e4fa 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
+2023-02-17 Tom Tromey <tom@tromey.com>
+
+ * opncls.c: Hoist the SECTION comment.
+
2023-02-17 Tom Tromey <tom@tromey.com>
* opncls.c (bfd_get_debug_link_info_1, separate_debug_file_exists)
diff --git a/bfd/opncls.c b/bfd/opncls.c
index 3fa2b03fdf9..4d0ca48ee78 100644
--- a/bfd/opncls.c
+++ b/bfd/opncls.c
@@ -37,6 +37,14 @@
#define S_IXOTH 0001 /* Execute by others. */
#endif
+/*
+SECTION
+ Opening and closing BFDs
+
+SUBSECTION
+ Functions for opening and closing
+*/
+
/* Counters used to initialize the bfd identifier. */
static unsigned int bfd_id_counter = 0;
@@ -185,14 +193,6 @@ _bfd_free_cached_info (bfd *abfd)
return true;
}
-/*
-SECTION
- Opening and closing BFDs
-
-SUBSECTION
- Functions for opening and closing
-*/
-
/*
FUNCTION
bfd_fopen
reply other threads:[~2023-02-20 21:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220213601.9EE7C3858D39@sourceware.org \
--to=tromey@sourceware.org \
--cc=bfd-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).