[binutils-gdb] Both FAIL and PASS "check sections 2"?

[binutils-gdb] Both FAIL and PASS "check sections 2"?

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=284e8cbae0d78a3a0a0e3ceeb862ce5ad149a7a2

commit 284e8cbae0d78a3a0a0e3ceeb862ce5ad149a7a2
Author: Alan Modra <amodra@gmail.com>
Date:   Tue Feb 21 16:15:59 2023 +1030

    Both FAIL and PASS "check sections 2"?
    
            * testsuite/ld-checks/checks.exp (check sections 2): Don't
            continue on with rest of test past first fail.

Diff:
---
 ld/testsuite/ld-checks/checks.exp | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/ld/testsuite/ld-checks/checks.exp b/ld/testsuite/ld-checks/checks.exp
index a0b6ade00c3..52b4088637a 100644
--- a/ld/testsuite/ld-checks/checks.exp
+++ b/ld/testsuite/ld-checks/checks.exp
@@ -61,17 +61,18 @@ proc section_check {} {
     # Make sure that we got some output from the linker
     if [string match "" $exec_output] then {
 	fail $test
-    }
+    } else {
 
-    # Now remove our expected error message
-    regsub -all ".*: section .data .* overlaps section .text .*" $exec_output "" exec_output
+	# Now remove our expected error message
+	regsub -all ".*: section .data .* overlaps section .text .*" $exec_output "" exec_output
 
-    # And check to see if anything else, (unexpected) was left
-    if [string match "" $exec_output] then {
-	pass $test
-    } else {
-	verbose -log "Unexpected linker message(s): $exec_output"
-	fail $test
+	# And check to see if anything else, (unexpected) was left
+	if [string match "" $exec_output] then {
+	    pass $test
+	} else {
+	    verbose -log "Unexpected linker message(s): $exec_output"
+	    fail $test
+	}
     }
 }