public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] chew.c printf of intptr_t
@ 2023-02-28  0:38 Alan Modra
  0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2023-02-28  0:38 UTC (permalink / raw)
  To: bfd-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=26c294bd1b8d95b421487294863eb1560b65580d

commit 26c294bd1b8d95b421487294863eb1560b65580d
Author: Alan Modra <amodra@gmail.com>
Date:   Tue Feb 28 11:04:33 2023 +1030

    chew.c printf of intptr_t
    
    Seen when building binutils with gcc -m32 on x86_64-linux.
    chew.c: In function ‘print’:
    chew.c:1434:59: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘intptr_t’ {aka ‘int’} [-Wformat=]
     1434 |     fprintf (stderr, "print: illegal print destination `%ld'\n", *isp);
          |                                                         ~~^      ~~~~
          |                                                           |      |
          |                                                           |      intptr_t {aka int}
          |                                                           long int
          |                                                         %d
    
            * chew.c: Include inttypes.h.
            (print): Use PRIdPTR for *isp.

Diff:
---
 bfd/doc/chew.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bfd/doc/chew.c b/bfd/doc/chew.c
index e8478969d64..5257bf42361 100644
--- a/bfd/doc/chew.c
+++ b/bfd/doc/chew.c
@@ -91,6 +91,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <stdint.h>
+#include <inttypes.h>
 
 #define DEF_SIZE 5000
 #define STACK 50
@@ -1431,7 +1432,7 @@ print (void)
   else if (*isp == 2)
     write_buffer (tos, stderr);
   else
-    fprintf (stderr, "print: illegal print destination `%ld'\n", *isp);
+    fprintf (stderr, "print: illegal print destination `%" PRIdPTR "'\n", *isp);
   isp--;
   tos--;
   icheck_range ();

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-28  0:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-28  0:38 [binutils-gdb] chew.c printf of intptr_t Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).