[binutils-gdb/binutils-2_40-branch] coff_get_normalized_symtab bfd_release

[binutils-gdb/binutils-2_40-branch] coff_get_normalized_symtab bfd_release

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=165accf07523db070eb25866a614b9a8f9c8e281

commit 165accf07523db070eb25866a614b9a8f9c8e281
Author: Alan Modra <amodra@gmail.com>
Date:   Wed Mar 22 10:13:46 2023 +1030

    coff_get_normalized_symtab bfd_release
    
    We can't free "internal" on errors, since bfd_coff_swap_sym_in may
    call bfd_alloc.  For example, _bfd_XXi_swap_sym_in may even create new
    sections, which use bfd_alloc'd memory.  If "internal" is freed, all
    more recently bfd_alloc'd memory is also freed.
    
            * coffgen.c (coff_get_normalized_symtab): Don't bfd_release on
            error.
    
    (cherry picked from commit bcefc6be9754d45fb9391993e6daaf01a68d9bd5)

Diff:
---
 bfd/coffgen.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/bfd/coffgen.c b/bfd/coffgen.c
index 74636a9e305..e9455c82a33 100644
--- a/bfd/coffgen.c
+++ b/bfd/coffgen.c
@@ -1756,10 +1756,7 @@ coff_get_normalized_symtab (bfd *abfd)
 
       /* PR 17512: Prevent buffer overrun.  */
       if (symbol_ptr->u.syment.n_numaux > ((raw_end - 1) - raw_src) / symesz)
-	{
-	  bfd_release (abfd, internal);
-	  return NULL;
-	}
+	return NULL;
 
       for (i = 0;
 	   i < symbol_ptr->u.syment.n_numaux;