From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2124) id 2CA7B3858C53; Mon, 17 Apr 2023 16:20:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CA7B3858C53 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Nick Clifton To: bfd-cvs@sourceware.org Subject: [binutils-gdb] Make the .rsrc section read only. X-Act-Checkin: binutils-gdb X-Git-Author: Nick Clifton X-Git-Refname: refs/heads/master X-Git-Oldrev: fb12bc1e8e7c5246e4eabcebdb4644c43bc7e6b9 X-Git-Newrev: c53c6186c8d69586a71a7f8284a9ed7fa8cb207f Message-Id: <20230417162007.2CA7B3858C53@sourceware.org> Date: Mon, 17 Apr 2023 16:20:07 +0000 (GMT) X-BeenThere: binutils-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Apr 2023 16:20:07 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dc53c6186c8d6= 9586a71a7f8284a9ed7fa8cb207f commit c53c6186c8d69586a71a7f8284a9ed7fa8cb207f Author: Nick Clifton Date: Mon Apr 17 17:19:21 2023 +0100 Make the .rsrc section read only. =20 PR 30142 * peXXigen.c (_bfd_XXi_swap_scnhdr_out): Do not force the .rsrc secti= on to be writeable. * rescoff.c (write_coff_file): Add the SEC_READONLY flag to the .rsrc= section. Diff: --- bfd/ChangeLog | 6 ++++++ bfd/peXXigen.c | 2 +- binutils/ChangeLog | 6 ++++++ binutils/rescoff.c | 2 +- 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index d9fe0d31a8d..0d2d9cf2fff 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2023-04-17 Nick Clifton + + PR 30142 + * peXXigen.c (_bfd_XXi_swap_scnhdr_out): Do not force the .rsrc + section to be writeable. + 2023-03-30 Nick Clifton =20 PR 30285 diff --git a/bfd/peXXigen.c b/bfd/peXXigen.c index d240e018a39..da53f349dd0 100644 --- a/bfd/peXXigen.c +++ b/bfd/peXXigen.c @@ -999,7 +999,7 @@ _bfd_XXi_swap_scnhdr_out (bfd * abfd, void * in, void *= out) { ".pdata", IMAGE_SCN_MEM_READ | IMAGE_SCN_CNT_INITIALIZED_DATA }, { ".rdata", IMAGE_SCN_MEM_READ | IMAGE_SCN_CNT_INITIALIZED_DATA }, { ".reloc", IMAGE_SCN_MEM_READ | IMAGE_SCN_CNT_INITIALIZED_DATA | IMAGE_S= CN_MEM_DISCARDABLE }, - { ".rsrc", IMAGE_SCN_MEM_READ | IMAGE_SCN_CNT_INITIALIZED_DATA | IMAGE_S= CN_MEM_WRITE }, + { ".rsrc", IMAGE_SCN_MEM_READ | IMAGE_SCN_CNT_INITIALIZED_DATA }, { ".text" , IMAGE_SCN_MEM_READ | IMAGE_SCN_CNT_CODE | IMAGE_SCN_MEM_EXECU= TE }, { ".tls", IMAGE_SCN_MEM_READ | IMAGE_SCN_CNT_INITIALIZED_DATA | IMAGE_S= CN_MEM_WRITE }, { ".xdata", IMAGE_SCN_MEM_READ | IMAGE_SCN_CNT_INITIALIZED_DATA }, diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 3b6f045e78a..f705b6c4622 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,9 @@ +2023-04-17 Nick Clifton + + PR 30142 + * rescoff.c (write_coff_file): Add the SEC_READONLY flag to the + .rsrc section.=20 + 2023-04-11 Nick Clifton =20 PR 30327 diff --git a/binutils/rescoff.c b/binutils/rescoff.c index 40a8f452a1f..5a99a284c14 100644 --- a/binutils/rescoff.c +++ b/binutils/rescoff.c @@ -477,7 +477,7 @@ write_coff_file (const char *filename, const char *targ= et, =20 sec =3D bfd_make_section_with_flags (abfd, ".rsrc", (SEC_HAS_CONTENTS | SEC_ALLOC - | SEC_LOAD | SEC_DATA)); + | SEC_LOAD | SEC_DATA | SEC_READONLY)); if (sec =3D=3D NULL) bfd_fatal ("bfd_make_section");