From: Alan Modra <amodra@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] sh4-linux segfaults running ld testsuite
Date: Wed, 19 Apr 2023 23:34:55 +0000 (GMT) [thread overview]
Message-ID: <20230419233455.D1BFE3858D37@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=509fdd5a8720250b8e0ddb5691ec94352c85e970
commit 509fdd5a8720250b8e0ddb5691ec94352c85e970
Author: Alan Modra <amodra@gmail.com>
Date: Thu Apr 20 07:01:22 2023 +0930
sh4-linux segfaults running ld testsuite
Segmentation fault
FAIL: pr22269-1 (static pie undefined weak)
and others running "visibility (hidden undef)" tests
No code has any right to access bfd_link_hash_entry u.def without
first checking the type, and SYMBOL_REFERENCES_LOCAL isn't sufficient.
* elf32-sh.c (sh_elf_finish_dynamic_symbol): Don't use relative
relocs in GOT unless symbol is defined.
Diff:
---
bfd/elf32-sh.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/bfd/elf32-sh.c b/bfd/elf32-sh.c
index fdcc5870890..499233d1355 100644
--- a/bfd/elf32-sh.c
+++ b/bfd/elf32-sh.c
@@ -6174,6 +6174,8 @@ sh_elf_finish_dynamic_symbol (bfd *output_bfd, struct bfd_link_info *info,
The entry in the global offset table will already have been
initialized in the relocate_section function. */
if (bfd_link_pic (info)
+ && (h->root.type == bfd_link_hash_defined
+ || h->root.type == bfd_link_hash_defweak)
&& SYMBOL_REFERENCES_LOCAL (info, h))
{
if (htab->fdpic_p)
reply other threads:[~2023-04-19 23:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419233455.D1BFE3858D37@sourceware.org \
--to=amodra@sourceware.org \
--cc=bfd-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).