public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] x86-64: conditionalize tests using --32
Date: Fri, 26 May 2023 08:14:48 +0000 (GMT)	[thread overview]
Message-ID: <20230526081448.BB6AF385842A@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a7aee0b5770d7c1c41ec38128729b9e6fd077ae4

commit a7aee0b5770d7c1c41ec38128729b9e6fd077ae4
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri May 26 10:13:53 2023 +0200

    x86-64: conditionalize tests using --32
    
    Using this option doesn't really work when no support for any 32-bit
    target was configured in (as is the case for at least cloudabi and
    rdos).

Diff:
---
 gas/testsuite/gas/i386/x86-64.exp | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/gas/testsuite/gas/i386/x86-64.exp b/gas/testsuite/gas/i386/x86-64.exp
index f412b17b6ef..48ec9c21929 100644
--- a/gas/testsuite/gas/i386/x86-64.exp
+++ b/gas/testsuite/gas/i386/x86-64.exp
@@ -33,6 +33,14 @@ if { ![gas_64_check] } then {
     return
 }
 
+proc gas_32_check { } {
+    global NM
+    global NMFLAGS
+
+    set status [gas_host_run "$NM $NMFLAGS --help" ""]
+    return [regexp "targets:.*i386" [lindex $status 1]];
+}
+
 global ASFLAGS
 set old_ASFLAGS "$ASFLAGS"
 set ASFLAGS "$ASFLAGS --64 --defsym x86_64=1 --strip-local-absolute"
@@ -582,8 +590,10 @@ if [is_elf_format] then {
     run_dump_test "mixed-mode-reloc64"
     run_dump_test "rela"
     run_dump_test "x86-64-ifunc"
-    run_dump_test "x86-64-opcode-inval"
-    run_dump_test "x86-64-opcode-inval-intel"
+    if { [gas_32_check] } then {
+	run_dump_test "x86-64-opcode-inval"
+	run_dump_test "x86-64-opcode-inval-intel"
+    }
     run_dump_test "intel-got64"
     run_dump_test "x86-64-localpic"
     run_dump_test "debug1"

                 reply	other threads:[~2023-05-26  8:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230526081448.BB6AF385842A@sourceware.org \
    --to=jbeulich@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).