From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1062) id 451813856634; Tue, 30 May 2023 04:24:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 451813856634 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Alan Modra To: bfd-cvs@sourceware.org Subject: [binutils-gdb] arm-pe objdump -P X-Act-Checkin: binutils-gdb X-Git-Author: Alan Modra X-Git-Refname: refs/heads/master X-Git-Oldrev: 20c52e689ac7ecda11c7002b797868c423f960ee X-Git-Newrev: 796029320e75a141570220224731c8151311f8d9 Message-Id: <20230530042437.451813856634@sourceware.org> Date: Tue, 30 May 2023 04:24:37 +0000 (GMT) X-BeenThere: binutils-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2023 04:24:37 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D796029320e75= a141570220224731c8151311f8d9 commit 796029320e75a141570220224731c8151311f8d9 Author: Alan Modra Date: Tue May 30 12:59:55 2023 +0930 arm-pe objdump -P =20 arm-pe looks to be a very old PE implementation, incompatible with current arm-wince-pe. arm-pe has different relocations and uses ARMMAGIC which has this comment: "I just made this up". Well, OK, I don't know the history but it was probably before Microsoft "just made up" their constants for ARM windows CE. =20 This patch supports objdump -P for arm-pe, and another magic constant that may appear in object files. (I don't think binutils generates files using ARMV7PEMAGIC aka IMAGE_FILE_MACHINE_ARMNT.) =20 * od-pe.c (is_pe_object_magic): Handle IMAGE_FILE_MACHINE_ARMNT and ARMMAGIC. Diff: --- binutils/od-pe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/binutils/od-pe.c b/binutils/od-pe.c index 5f03bd8c3da..5a57a6e7486 100644 --- a/binutils/od-pe.c +++ b/binutils/od-pe.c @@ -450,6 +450,7 @@ is_pe_object_magic (unsigned short magic) case IMAGE_FILE_MACHINE_ALPHA: case IMAGE_FILE_MACHINE_ARM: case IMAGE_FILE_MACHINE_ARM64: + case IMAGE_FILE_MACHINE_ARMNT: case IMAGE_FILE_MACHINE_I386: case IMAGE_FILE_MACHINE_IA64: case IMAGE_FILE_MACHINE_POWERPC: @@ -457,6 +458,7 @@ is_pe_object_magic (unsigned short magic) case IMAGE_FILE_MACHINE_AMD64: // FIXME: Add more machine numbers. return true; + case 0x0a00: /* ARMMAGIC */ case 0x0500: /* SH_ARCH_MAGIC_BIG */ case 0x0550: /* SH_ARCH_MAGIC_LITTLE */ case 0x0b00: /* MCore */