From: Alan Modra <amodra@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] Remove BFD_FAIL in cpu-sh.c
Date: Thu, 1 Jun 2023 00:33:19 +0000 (GMT) [thread overview]
Message-ID: <20230601003319.649E73858031@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d18f60c747c220ef8ca118b61e5db5c5cdf8f28b
commit d18f60c747c220ef8ca118b61e5db5c5cdf8f28b
Author: Alan Modra <amodra@gmail.com>
Date: Tue May 30 19:46:24 2023 +0930
Remove BFD_FAIL in cpu-sh.c
The assertions in cpu-sh.c can be triggered by passing bogus values
in disassemble_info.mach. This doesn't cause any bfd misbehaviour.
* cpu-sh.c (sh_get_arch_from_bfd_mach): Remove BFD_FAIL.
(sh_get_arch_up_from_bfd_mach): Likewise.
Diff:
---
bfd/cpu-sh.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/bfd/cpu-sh.c b/bfd/cpu-sh.c
index afea21a8dac..578ff086c3f 100644
--- a/bfd/cpu-sh.c
+++ b/bfd/cpu-sh.c
@@ -117,9 +117,6 @@ sh_get_arch_from_bfd_mach (unsigned long mach)
else
i++;
- /* Machine not found. */
- BFD_FAIL();
-
return SH_ARCH_UNKNOWN_ARCH;
}
@@ -139,9 +136,6 @@ sh_get_arch_up_from_bfd_mach (unsigned long mach)
else
i++;
- /* Machine not found. */
- BFD_FAIL();
-
return SH_ARCH_UNKNOWN_ARCH;
}
reply other threads:[~2023-06-01 0:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601003319.649E73858031@sourceware.org \
--to=amodra@sourceware.org \
--cc=bfd-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).