From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7850) id 42DB43858CDB; Thu, 1 Jun 2023 05:58:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 42DB43858CDB Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Indu Bhagat To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org Subject: [binutils-gdb] libsframe: minor fixups in flip_fre related functions X-Act-Checkin: binutils-gdb X-Git-Author: Indu Bhagat X-Git-Refname: refs/heads/master X-Git-Oldrev: ec2260af61501798d00e41c3180c63d25b11439c X-Git-Newrev: a5ffdcafc76c3f77c1c05fabe1544e004e9ef358 Message-Id: <20230601055836.42DB43858CDB@sourceware.org> Date: Thu, 1 Jun 2023 05:58:36 +0000 (GMT) X-BeenThere: binutils-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2023 05:58:36 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Da5ffdcafc76c= 3f77c1c05fabe1544e004e9ef358 commit a5ffdcafc76c3f77c1c05fabe1544e004e9ef358 Author: Indu Bhagat Date: Wed May 31 22:55:41 2023 -0700 libsframe: minor fixups in flip_fre related functions =20 libsframe/ * sframe.c (flip_fre_start_address): Remove unnecessary type cast. Use uint16_t instead of unsigned short. (flip_fre_stack_offsets): Likewise. Diff: --- libsframe/sframe.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libsframe/sframe.c b/libsframe/sframe.c index dadce2c1262..97b49106e39 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -221,30 +221,28 @@ sframe_header_sanity_check_p (sframe_header *hp) /* Flip the start address pointed to by FP. */ =20 static void -flip_fre_start_address (char *fp, unsigned int fre_type) +flip_fre_start_address (char *addr, unsigned int fre_type) { - void *start =3D (void*)fp; if (fre_type =3D=3D SFRAME_FRE_TYPE_ADDR2) { - unsigned short *start_addr =3D (unsigned short *)(start); + uint16_t *start_addr =3D (uint16_t *)addr; swap_thing (*start_addr); } else if (fre_type =3D=3D SFRAME_FRE_TYPE_ADDR4) { - uint32_t *start_addr =3D (uint32_t *)(start); + uint32_t *start_addr =3D (uint32_t *)addr; swap_thing (*start_addr); } } =20 static void -flip_fre_stack_offsets (char *fp, uint8_t offset_size, uint8_t offset_cnt) +flip_fre_stack_offsets (char *offsets, uint8_t offset_size, uint8_t offset= _cnt) { int j; - void *offsets =3D (void *)fp; =20 if (offset_size =3D=3D SFRAME_FRE_OFFSET_2B) { - unsigned short *ust =3D (unsigned short *)offsets; + uint16_t *ust =3D (uint16_t *)offsets; for (j =3D offset_cnt; j > 0; ust++, j--) swap_thing (*ust); }