From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7850) id 45316385770B; Thu, 1 Jun 2023 16:55:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 45316385770B Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Indu Bhagat To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org Subject: [binutils-gdb] libsframe: avoid using magic number X-Act-Checkin: binutils-gdb X-Git-Author: Indu Bhagat X-Git-Refname: refs/heads/master X-Git-Oldrev: a5ffdcafc76c3f77c1c05fabe1544e004e9ef358 X-Git-Newrev: d987df5c95340a8b41b23d68ad6a8f9f33485835 Message-Id: <20230601165519.45316385770B@sourceware.org> Date: Thu, 1 Jun 2023 16:55:19 +0000 (GMT) X-BeenThere: binutils-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2023 16:55:19 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dd987df5c9534= 0a8b41b23d68ad6a8f9f33485835 commit d987df5c95340a8b41b23d68ad6a8f9f33485835 Author: Indu Bhagat Date: Thu Jun 1 09:41:04 2023 -0700 libsframe: avoid using magic number =20 Define a new constant for the maximum number of stack offsets handled in libsframe, and use it. Note that the SFrame format does not define such a constant (limit). This is an implmentation-defined constant in libsframe. =20 include/ * sframe-api.h (MAX_NUM_STACK_OFFSETS): New definition. libsframe/ * sframe.c (sframe_fre_sanity_check_p): Use it. Diff: --- include/sframe-api.h | 5 ++++- libsframe/sframe.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/sframe-api.h b/include/sframe-api.h index 405e30c27e8..3245bc8ac90 100644 --- a/include/sframe-api.h +++ b/include/sframe-api.h @@ -31,7 +31,10 @@ extern "C" typedef struct sframe_decoder_ctx sframe_decoder_ctx; typedef struct sframe_encoder_ctx sframe_encoder_ctx; =20 -#define MAX_OFFSET_BYTES (SFRAME_FRE_OFFSET_4B * 2 * 3) +#define MAX_NUM_STACK_OFFSETS 3 + +#define MAX_OFFSET_BYTES \ + ((SFRAME_FRE_OFFSET_4B * 2 * MAX_NUM_STACK_OFFSETS)) =20 /* User interfacing SFrame Row Entry. An abstraction provided by libsframe so the consumer is decoupled from diff --git a/libsframe/sframe.c b/libsframe/sframe.c index 97b49106e39..a97c64f7a9b 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -299,7 +299,7 @@ sframe_fre_sanity_check_p (sframe_frame_row_entry *frep) return false; =20 offset_cnt =3D sframe_fre_get_offset_count (fre_info); - if (offset_cnt > 3) + if (offset_cnt > MAX_NUM_STACK_OFFSETS) return false; =20 return true;