From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1062) id DE0363858404; Fri, 2 Jun 2023 00:12:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DE0363858404 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Alan Modra To: bfd-cvs@sourceware.org Subject: [binutils-gdb] Re: bfd_close and target free_cached_memory X-Act-Checkin: binutils-gdb X-Git-Author: Alan Modra X-Git-Refname: refs/heads/master X-Git-Oldrev: e0ce6dde97881435d33652572789b94c846cacde X-Git-Newrev: 63188cb5c3e2814d6527d0309af4db8634e8cdaa Message-Id: <20230602001224.DE0363858404@sourceware.org> Date: Fri, 2 Jun 2023 00:12:24 +0000 (GMT) X-BeenThere: binutils-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2023 00:12:25 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D63188cb5c3e2= 814d6527d0309af4db8634e8cdaa commit 63188cb5c3e2814d6527d0309af4db8634e8cdaa Author: Alan Modra Date: Fri Jun 2 09:00:41 2023 +0930 Re: bfd_close and target free_cached_memory =20 _bfd_delete_bfd can be called early, before the target xvec is set up. =20 * opncls.c (_bfd_delete_bfd): Don't segfault on NULL xvec. Diff: --- bfd/opncls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bfd/opncls.c b/bfd/opncls.c index b0c23b4201c..7cb09a108e5 100644 --- a/bfd/opncls.c +++ b/bfd/opncls.c @@ -157,7 +157,7 @@ static void _bfd_delete_bfd (bfd *abfd) { /* Give the target _bfd_free_cached_info a chance to free memory. */ - if (abfd->memory) + if (abfd->memory && abfd->xvec) bfd_free_cached_info (abfd); =20 /* The target _bfd_free_cached_info may not have done anything.. */