From: Alan Modra <amodra@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] Re: More ecoff sanity checks
Date: Sat, 3 Jun 2023 08:06:30 +0000 (GMT) [thread overview]
Message-ID: <20230603080630.3F5A93857341@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c6e6e3ab2b70458d34c4a7a2e7e1637d38d49e8f
commit c6e6e3ab2b70458d34c4a7a2e7e1637d38d49e8f
Author: Alan Modra <amodra@gmail.com>
Date: Sat Jun 3 12:39:06 2023 +0930
Re: More ecoff sanity checks
Yet another fuzzer fix.
* ecoff.c (ecoff_slurp_symbolic_header <FIX>): Zero counts when
associated pointer is zero.
(_bfd_ecoff_slurp_symbolic_info): Remove now unnecessary check.
Diff:
---
bfd/ecoff.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/bfd/ecoff.c b/bfd/ecoff.c
index f2930569f21..c4c2e530be0 100644
--- a/bfd/ecoff.c
+++ b/bfd/ecoff.c
@@ -468,6 +468,23 @@ ecoff_slurp_symbolic_header (bfd *abfd)
goto error_return;
}
+#define FIX(start, count) \
+ if (internal_symhdr->start == 0) \
+ internal_symhdr->count = 0;
+
+ FIX (cbLineOffset, cbLine);
+ FIX (cbDnOffset, idnMax);
+ FIX (cbPdOffset, ipdMax);
+ FIX (cbSymOffset, isymMax);
+ FIX (cbOptOffset, ioptMax);
+ FIX (cbAuxOffset, iauxMax);
+ FIX (cbSsOffset, issMax);
+ FIX (cbSsExtOffset, issExtMax);
+ FIX (cbFdOffset, ifdMax);
+ FIX (cbRfdOffset, crfd);
+ FIX (cbExtOffset, iextMax);
+#undef FIX
+
/* Now we can get the correct number of symbols. */
abfd->symcount = internal_symhdr->isymMax + internal_symhdr->iextMax;
@@ -580,7 +597,7 @@ _bfd_ecoff_slurp_symbolic_info (bfd *abfd,
/* Get pointers for the numeric offsets in the HDRR structure. */
#define FIX(start, count, ptr, type) \
- if (internal_symhdr->start == 0 || internal_symhdr->count == 0) \
+ if (internal_symhdr->count == 0) \
debug->ptr = NULL; \
else \
debug->ptr = (type) ((char *) raw \
next reply other threads:[~2023-06-03 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 8:06 Alan Modra [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-02 0:12 Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230603080630.3F5A93857341@sourceware.org \
--to=amodra@sourceware.org \
--cc=bfd-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).