From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7850) id 465C43858C5F; Tue, 6 Jun 2023 17:52:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 465C43858C5F Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Indu Bhagat To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org Subject: [binutils-gdb] libsframe: fix cosmetic issues and typos X-Act-Checkin: binutils-gdb X-Git-Author: Indu Bhagat X-Git-Refname: refs/heads/master X-Git-Oldrev: d3f340763bab7c74838ebb481fd7ff93acd9f00c X-Git-Newrev: f4af42724b8c968c355796b561434250aa605458 Message-Id: <20230606175242.465C43858C5F@sourceware.org> Date: Tue, 6 Jun 2023 17:52:42 +0000 (GMT) X-BeenThere: binutils-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2023 17:52:42 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Df4af42724b8c= 968c355796b561434250aa605458 commit f4af42724b8c968c355796b561434250aa605458 Author: Indu Bhagat Date: Tue Jun 6 10:50:07 2023 -0700 libsframe: fix cosmetic issues and typos =20 include/ * sframe-api.h (sframe_decoder_get_num_fidx): Use extern. libsframe/ * sframe-dump.c (dump_sframe_func_with_fres): Fix line length. * sframe.c (sframe_frame_row_entry_copy): Likewise. (sframe_decode_fre_start_address): Use the intended type uint32= _t. Diff: --- include/sframe-api.h | 2 +- libsframe/sframe-dump.c | 5 +++-- libsframe/sframe.c | 5 +++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/sframe-api.h b/include/sframe-api.h index 3245bc8ac90..df1f5ccef4c 100644 --- a/include/sframe-api.h +++ b/include/sframe-api.h @@ -122,7 +122,7 @@ sframe_decoder_get_abi_arch (sframe_decoder_ctx *dctx); =20 /* Return the number of function descriptor entries in the SFrame decoder DCTX. */ -unsigned int +extern unsigned int sframe_decoder_get_num_fidx (sframe_decoder_ctx *dctx); =20 /* Get the fixed FP offset from the decoder context DCTX. */ diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c index 77aa87d67a1..6d266392cd7 100644 --- a/libsframe/sframe-dump.c +++ b/libsframe/sframe-dump.c @@ -2,7 +2,7 @@ =20 Copyright (C) 2022-2023 Free Software Foundation, Inc. =20 - his file is part of libsframe. + This file is part of libsframe. =20 This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -134,7 +134,8 @@ dump_sframe_func_with_fres (sframe_decoder_ctx *sfd_ctx, =20 char temp[100]; =20 - printf ("\n %-7s%-8s %-10s%-10s%-13s", "STARTPC", fde_type_marker, "C= FA", "FP", "RA"); + printf ("\n %-7s%-8s %-10s%-10s%-13s", + "STARTPC", fde_type_marker, "CFA", "FP", "RA"); for (j =3D 0; j < num_fres; j++) { sframe_decoder_get_fre (sfd_ctx, funcidx, j, &fre); diff --git a/libsframe/sframe.c b/libsframe/sframe.c index b05fed97e61..a7615329767 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -667,7 +667,8 @@ sframe_fre_get_ra_mangled_p (sframe_decoder_ctx *dctx A= TTRIBUTE_UNUSED, } =20 static int -sframe_frame_row_entry_copy (sframe_frame_row_entry *dst, sframe_frame_row= _entry *src) +sframe_frame_row_entry_copy (sframe_frame_row_entry *dst, + sframe_frame_row_entry *src) { int err =3D 0; =20 @@ -711,7 +712,7 @@ sframe_decode_fre_start_address (const char *fre_buf, else if (fre_type =3D=3D SFRAME_FRE_TYPE_ADDR4) { uint32_t *uit =3D (uint32_t *)fre_buf; - int32_t tmp =3D 0; + uint32_t tmp =3D 0; memcpy (&tmp, uit, addr_size); saddr =3D (uint32_t)tmp; }