From: liu & zhensong <liuzhensong@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] LoongArch: Fix ld "undefined reference" error with --enable-shared
Date: Fri, 16 Jun 2023 09:42:37 +0000 (GMT) [thread overview]
Message-ID: <20230616094237.6CE4B3854E4B@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d2fddb6d783320726328707d53aa74e3c48616ef
commit d2fddb6d783320726328707d53aa74e3c48616ef
Author: mengqinggang <mengqinggang@loongson.cn>
Date: Tue Jun 13 16:07:12 2023 +0800
LoongArch: Fix ld "undefined reference" error with --enable-shared
Because _bfd_read_unsigned_leb128 is hidden visibility, so it can't
be referenced out of shared object.
The new function loongarch_get_uleb128_length just used to call
_bfd_read_unsigned_leb128.
bfd/ChangeLog:
* elfxx-loongarch.c (loongarch_get_uleb128_length): New function.
* elfxx-loongarch.h (loongarch_get_uleb128_length): New function.
gas/ChangeLog:
* config/tc-loongarch.c (md_apply_fix): Use
loongarch_get_uleb128_length.
Diff:
---
bfd/elfxx-loongarch.c | 7 +++++++
bfd/elfxx-loongarch.h | 2 ++
gas/config/tc-loongarch.c | 2 +-
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/bfd/elfxx-loongarch.c b/bfd/elfxx-loongarch.c
index ac644fff2f6..cb312c46bb2 100644
--- a/bfd/elfxx-loongarch.c
+++ b/bfd/elfxx-loongarch.c
@@ -1944,3 +1944,10 @@ loongarch_write_unsigned_leb128 (bfd_byte *p, unsigned int len, bfd_vma value)
while (len);
return p;
}
+
+int loongarch_get_uleb128_length (bfd_byte *buf)
+{
+ unsigned int len = 0;
+ _bfd_read_unsigned_leb128 (NULL, buf, &len);
+ return len;
+}
diff --git a/bfd/elfxx-loongarch.h b/bfd/elfxx-loongarch.h
index cb02af4fe73..627c5db7bcc 100644
--- a/bfd/elfxx-loongarch.h
+++ b/bfd/elfxx-loongarch.h
@@ -44,6 +44,8 @@ bfd_elf64_loongarch_set_data_segment_info (struct bfd_link_info *, int *);
bfd_byte *
loongarch_write_unsigned_leb128 (bfd_byte *p, unsigned int len, bfd_vma value);
+int loongarch_get_uleb128_length (bfd_byte *buf);
+
/* TRUE if this is a PLT reference to a local IFUNC. */
#define PLT_LOCAL_IFUNC_P(INFO, H) \
((H)->dynindx == -1 \
diff --git a/gas/config/tc-loongarch.c b/gas/config/tc-loongarch.c
index 5ca9de47629..d1c5ce287e4 100644
--- a/gas/config/tc-loongarch.c
+++ b/gas/config/tc-loongarch.c
@@ -1382,7 +1382,7 @@ md_apply_fix (fixS *fixP, valueT *valP, segT seg ATTRIBUTE_UNUSED)
case BFD_RELOC_LARCH_SUB_ULEB128:
{
unsigned int len = 0;
- _bfd_read_unsigned_leb128 (NULL, (bfd_byte *)buf, &len);
+ len = loongarch_get_uleb128_length ((bfd_byte *)buf);
bfd_byte *endp = (bfd_byte*) buf + len -1;
/* Clean the uleb128 value to 0. Do not reduce the length. */
memset (buf, 0x80, len - 1);
reply other threads:[~2023-06-16 9:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616094237.6CE4B3854E4B@sourceware.org \
--to=liuzhensong@sourceware.org \
--cc=bfd-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).