From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sjames@sourceware.org>
Received: by sourceware.org (Postfix, from userid 7919)
 id 0551D3858D38; Thu, 17 Aug 2023 04:21:10 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0551D3858D38
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Sam James <sjames@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] ld: ld-lib.exp: log failed dump.out contents for
 debugging
X-Act-Checkin: binutils-gdb
X-Git-Author: Sam James <sam@gentoo.org>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: 4c072eb6297e6fed85cd6ab502fe18e1cd1d35b4
X-Git-Newrev: 646657284f6b62a71a6869826e951b3def4d73a6
Message-Id: <20230817042110.0551D3858D38@sourceware.org>
Date: Thu, 17 Aug 2023 04:21:10 +0000 (GMT)
X-BeenThere: binutils-cvs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils-cvs mailing list <binutils-cvs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils-cvs>,
 <mailto:binutils-cvs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils-cvs/>
List-Help: <mailto:binutils-cvs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils-cvs>,
 <mailto:binutils-cvs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Aug 2023 04:21:10 -0000

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D646657284f6b=
62a71a6869826e951b3def4d73a6

commit 646657284f6b62a71a6869826e951b3def4d73a6
Author: Sam James <sam@gentoo.org>
Date:   Wed Aug 16 07:21:53 2023 +0100

    ld: ld-lib.exp: log failed dump.out contents for debugging
   =20
    If we're using dump_prog in a test which fails, log the dump.out conten=
ts
    to ld.log to aid debugging.
   =20
    This avoids needing to ask reporters to manually run e.g. `objdump` com=
mands
    when making bug reports.
   =20
    PR30722
            * ld/testsuite/lib/ld-lib.exp: Log failed dump.out contents to =
aid
            debugging.
   =20
    Approved-by: Nick Clifton <nickc@redhat.com>
    Signed-off-by: Sam James <sam@gentoo.org>

Diff:
---
 ld/testsuite/lib/ld-lib.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ld/testsuite/lib/ld-lib.exp b/ld/testsuite/lib/ld-lib.exp
index 918464069a9..aca303e0728 100644
--- a/ld/testsuite/lib/ld-lib.exp
+++ b/ld/testsuite/lib/ld-lib.exp
@@ -640,7 +640,7 @@ proc run_ld_link_tests { ldtests args } {
 		    remote_upload host "dump.out"
=20
 		    if { [regexp_diff "dump.out" "$srcdir/$subdir/$dumpfile"] } then {
-			verbose "output is [file_contents "dump.out"]" 2
+			verbose -log "output is [file_contents "dump.out"]" 2
 			set failed 1
 			remote_file build delete "dump.out"
 			remote_file host delete "dump.out"
@@ -1067,7 +1067,7 @@ proc run_cc_link_tests { ldtests } {
 		    }
=20
 		    if { [regexp_diff "dump.out" "$srcdir/$subdir/$dumpfile"] } then {
-			verbose "output is [file_contents "dump.out"]" 2
+			verbose -log "output is [file_contents "dump.out"]" 2
 			set failed 1
 			break
 		    }