[binutils-gdb] x86: remove indirection from bx[] and di_si[]

[binutils-gdb] x86: remove indirection from bx[] and di_si[]

[Jan Beulich]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=069a1561b76532964b1dcc3bdd8f745e927358d6

commit 069a1561b76532964b1dcc3bdd8f745e927358d6
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Aug 18 08:58:15 2023 +0200

    x86: remove indirection from bx[] and di_si[]
    
    The longest register name is 3 characters (plus a nul one), so using a
    4- or 8-byte pointer to get at it is neither space nor time efficient.
    Embed the names right into the array. For PIE this also slightly reduces
    the number of base relocations in the final image.

Diff:
---
 gas/config/tc-i386.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index 3b00a1bc612..604a6355eba 100644
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -12250,13 +12250,13 @@ i386_index_check (const char *operand_string)
       /* Memory operands of string insns are special in that they only allow
 	 a single register (rDI, rSI, or rBX) as their memory address.  */
       const reg_entry *expected_reg;
-      static const char *di_si[][2] =
+      static const char di_si[][2][4] =
 	{
 	  { "esi", "edi" },
 	  { "si", "di" },
 	  { "rsi", "rdi" }
 	};
-      static const char *bx[] = { "ebx", "bx", "rbx" };
+      static const char bx[][4] = { "ebx", "bx", "rbx" };
 
       kind = "string address";