* [binutils-gdb] opcodes i386 and ia64 gen file warnings
@ 2023-08-26 1:52 Alan Modra
0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2023-08-26 1:52 UTC (permalink / raw)
To: bfd-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d2ac569f7b443aef7b2be2f0c80d8ab0d67b4292
commit d2ac569f7b443aef7b2be2f0c80d8ab0d67b4292
Author: Alan Modra <amodra@gmail.com>
Date: Sat Aug 26 11:17:47 2023 +0930
opcodes i386 and ia64 gen file warnings
i386: warning: format ‘%u’ expects argument of type ‘unsigned int’,
but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]
ia64: warning: ignoring return value of ‘fgets’
* i386-gen.c (process_i386_opcodes): Correct format string.
* ia64-gen.c (load_insn_classes, load_depfile): Don't ignore
fgets return value.
Diff:
---
opcodes/i386-gen.c | 2 +-
opcodes/ia64-gen.c | 6 ++++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/opcodes/i386-gen.c b/opcodes/i386-gen.c
index 30430a2f58a..c46d6a5e88d 100644
--- a/opcodes/i386-gen.c
+++ b/opcodes/i386-gen.c
@@ -1841,7 +1841,7 @@ process_i386_opcodes (FILE *table)
fprintf (fp, "#define MN_%s ", str);
free (str);
str = mkident (next);
- fprintf (fp, "(MN_%s + %u)\n", str, l1 - l);
+ fprintf (fp, "(MN_%s + %zu)\n", str, l1 - l);
}
else
{
diff --git a/opcodes/ia64-gen.c b/opcodes/ia64-gen.c
index ad91e77248e..0118dd78757 100644
--- a/opcodes/ia64-gen.c
+++ b/opcodes/ia64-gen.c
@@ -607,7 +607,8 @@ load_insn_classes (void)
fail (_("can't find ia64-ic.tbl for reading\n"));
/* Discard first line. */
- fgets (buf, sizeof(buf), fp);
+ if (fgets (buf, sizeof(buf), fp) == NULL)
+ return;
while (!feof (fp))
{
@@ -808,7 +809,8 @@ load_depfile (const char *filename, enum ia64_dependency_mode mode)
if (fp == NULL)
fail (_("can't find %s for reading\n"), filename);
- fgets (buf, sizeof(buf), fp);
+ if (fgets (buf, sizeof(buf), fp) == NULL)
+ return;
while (!feof (fp))
{
char *name, *tmp;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-08-26 1:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-26 1:52 [binutils-gdb] opcodes i386 and ia64 gen file warnings Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).