[binutils-gdb] comdat_hash memory leaks

[binutils-gdb] comdat_hash memory leaks

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8606b47e94078e77a53f3cd714272c853d2add22

commit 8606b47e94078e77a53f3cd714272c853d2add22
Author: Alan Modra <amodra@gmail.com>
Date:   Sun Aug 27 13:19:01 2023 +0930

    comdat_hash memory leaks
    
    Entries added to the hash table with bfd_malloc ought to be freed when
    the hash table is deleted.  This patch adds the necessary del_f to the
    htab_create call, and delays creating the table until an
    IMAGE_SCN_LNK_COMDAT symbol is read.
    
            * peicode.h (pe_mkobject): Move comdat_hash creation..
            (htab_hash_flags, htab_eq_flags): ..and these support functions..
            * coffcode.h (handle_COMDAT): ..to here, renaming support to
            (comdat_hashf, comdat_eqf): ..this and adding..
            (comdat_delf): ..this new function.

Diff:
---
 bfd/coffcode.h | 31 +++++++++++++++++++++++++++++++
 bfd/peicode.h  | 17 -----------------
 2 files changed, 31 insertions(+), 17 deletions(-)

diff --git a/bfd/coffcode.h b/bfd/coffcode.h
index 2d40c5cfcac..03c1788a1c9 100644
--- a/bfd/coffcode.h
+++ b/bfd/coffcode.h
@@ -853,6 +853,29 @@ styp_to_sec_flags (bfd *abfd,
 
 #else /* COFF_WITH_PE */
 
+static hashval_t
+comdat_hashf (const void *entry)
+{
+  const struct comdat_hash_entry *fe = entry;
+  return fe->target_index;
+}
+
+static int
+comdat_eqf (const void *e1, const void *e2)
+{
+  const struct comdat_hash_entry *fe1 = e1;
+  const struct comdat_hash_entry *fe2 = e2;
+  return fe1->target_index == fe2->target_index;
+}
+
+static void
+comdat_delf (void *ent)
+{
+  struct comdat_hash_entry *e = ent;
+  free (e->symname);
+  free (e);
+}
+
 static struct comdat_hash_entry *
 find_flags (htab_t comdat_hash, int target_index)
 {
@@ -1085,6 +1108,14 @@ static bool
 handle_COMDAT (bfd *abfd, flagword *sec_flags, const char *name,
 	       asection *section)
 {
+  if (pe_data (abfd)->comdat_hash == NULL)
+    {
+      pe_data (abfd)->comdat_hash = htab_create (10, comdat_hashf, comdat_eqf,
+						 comdat_delf);
+      if (pe_data (abfd)->comdat_hash == NULL)
+	return false;
+    }
+
   if (htab_elements (pe_data (abfd)->comdat_hash) == 0)
     if (! fill_comdat_hash (abfd))
       return false;
diff --git a/bfd/peicode.h b/bfd/peicode.h
index e1d06606575..1ff13b0313d 100644
--- a/bfd/peicode.h
+++ b/bfd/peicode.h
@@ -255,21 +255,6 @@ coff_swap_scnhdr_in (bfd * abfd, void * ext, void * in)
 #endif
 }
 
-static hashval_t
-htab_hash_flags (const void *entry)
-{
-  const struct comdat_hash_entry *fe = entry;
-  return fe->target_index;
-}
-
-static int
-htab_eq_flags (const void *e1, const void *e2)
-{
-  const struct comdat_hash_entry *fe1 = e1;
-  const struct comdat_hash_entry *fe2 = e2;
-  return fe1->target_index == fe2->target_index;
-}
-
 static bool
 pe_mkobject (bfd * abfd)
 {
@@ -306,8 +291,6 @@ pe_mkobject (bfd * abfd)
   pe->dos_message[14] = 0x24;
   pe->dos_message[15] = 0x0;
 
-  pe->comdat_hash = htab_create (10, htab_hash_flags, htab_eq_flags, NULL);
-
   memset (& pe->pe_opthdr, 0, sizeof pe->pe_opthdr);
 
   bfd_coff_long_section_names (abfd)