From: Nick Clifton <nickc@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] Fix: addr2line testsuite fails when targeting PowerPC 64 big-endian with ELFv2 ABI
Date: Thu, 5 Oct 2023 13:50:29 +0000 (GMT) [thread overview]
Message-ID: <20231005135029.4BBF6385CC8F@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c4e0d285cfccc6c7d90c34441cbe52a4c471e4c0
commit c4e0d285cfccc6c7d90c34441cbe52a4c471e4c0
Author: A. Wilcox <awilfox@adelielinux.org>
Date: Thu Oct 5 14:49:51 2023 +0100
Fix: addr2line testsuite fails when targeting PowerPC 64 big-endian with ELFv2 ABI
PR 30916
* testsuite/binutils-all/addr2line.exp: Do not use PowerPC specific options when working with a MUSL target.
Diff:
---
binutils/ChangeLog | 6 ++++++
binutils/testsuite/binutils-all/addr2line.exp | 3 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index dbb5e8d094a..4d187bda5d8 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,9 @@
+2023-10-05 A. Wilcox <awilfox@adelielinux.org>w
+
+ PR 30916
+ * testsuite/binutils-all/addr2line.exp: Do not use PowerPC
+ specific options when working with a MUSL target.
+
2023-10-02 Vsevolod Alekseyev <sevaa@sprynet.com>
PR 29267
diff --git a/binutils/testsuite/binutils-all/addr2line.exp b/binutils/testsuite/binutils-all/addr2line.exp
index 82a29d5e4e4..908090a7b44 100644
--- a/binutils/testsuite/binutils-all/addr2line.exp
+++ b/binutils/testsuite/binutils-all/addr2line.exp
@@ -20,7 +20,8 @@ set dot ""
set exe [exeext]
# powerpc64 function symbols are on descriptors rather than code.
-if [istarget powerpc64-*-*] {
+# MUSL uses the ELFv2 ABI for PowerPC, so the problem does not apply there.
+if { [istarget powerpc64-*-*] && ![istarget powerpc64-*-musl] } {
set opts --synthetic
set dot {\.}
}
reply other threads:[~2023-10-05 13:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005135029.4BBF6385CC8F@sourceware.org \
--to=nickc@sourceware.org \
--cc=bfd-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).