public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Jan-Benedict Glaw <jbglaw@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] [opcodes] ARC + PPC: Fix -Walloc-size warnings
Date: Tue, 21 Nov 2023 16:55:19 +0000 (GMT)	[thread overview]
Message-ID: <20231121165519.DA91F3858D35@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=54195469c18ec9873cc5ba6907f768509473fa9b

commit 54195469c18ec9873cc5ba6907f768509473fa9b
Author: Jan-Benedict Glaw <jbglaw@lug-owl.de>
Date:   Tue Nov 21 17:53:44 2023 +0100

    [opcodes] ARC + PPC: Fix -Walloc-size warnings
    
    Recently, -Walloc-size warnings started to kick in. Fix these two
    calloc() calls to match the intended usage pattern.
    
    opcodes/ChangeLog:
    
            * arc-dis.c (init_arc_disasm_info): Fix calloc() call.
            * ppc-dis.c (powerpc_init_dialect): Ditto.

Diff:
---
 opcodes/arc-dis.c | 2 +-
 opcodes/ppc-dis.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/opcodes/arc-dis.c b/opcodes/arc-dis.c
index 59b668ff64e..7498e75cee2 100644
--- a/opcodes/arc-dis.c
+++ b/opcodes/arc-dis.c
@@ -147,7 +147,7 @@ static bool
 init_arc_disasm_info (struct disassemble_info *info)
 {
   struct arc_disassemble_info *arc_infop
-    = calloc (sizeof (*arc_infop), 1);
+    = calloc (1, sizeof (*arc_infop));
 
   if (arc_infop == NULL)
     return false;
diff --git a/opcodes/ppc-dis.c b/opcodes/ppc-dis.c
index d97137d8b71..4d5652ebfeb 100644
--- a/opcodes/ppc-dis.c
+++ b/opcodes/ppc-dis.c
@@ -348,7 +348,7 @@ powerpc_init_dialect (struct disassemble_info *info)
 {
   ppc_cpu_t dialect = 0;
   ppc_cpu_t sticky = 0;
-  struct dis_private *priv = calloc (sizeof (*priv), 1);
+  struct dis_private *priv = calloc (1, sizeof (*priv));
 
   if (priv == NULL)
     return;

                 reply	other threads:[~2023-11-21 16:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231121165519.DA91F3858D35@sourceware.org \
    --to=jbglaw@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).