* [binutils-gdb] LoongArch: fix internal error when as handling unsupported modifier.
@ 2023-11-22 6:43 liu & zhensong
0 siblings, 0 replies; only message in thread
From: liu & zhensong @ 2023-11-22 6:43 UTC (permalink / raw)
To: bfd-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=df4ffdd8c87b32357f929fb4a861760038f3bbb8
commit df4ffdd8c87b32357f929fb4a861760038f3bbb8
Author: Lulu Cai <cailulu@loongson.cn>
Date: Wed Nov 15 19:20:53 2023 +0800
LoongArch: fix internal error when as handling unsupported modifier.
Diff:
---
bfd/elfxx-loongarch.c | 3 ---
gas/config/loongarch-parse.y | 6 +++++-
gas/testsuite/gas/loongarch/reloc_type.d | 3 +++
gas/testsuite/gas/loongarch/reloc_type.l | 2 ++
gas/testsuite/gas/loongarch/reloc_type.s | 3 +++
5 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/bfd/elfxx-loongarch.c b/bfd/elfxx-loongarch.c
index a970a257aa9..7f298c08fd3 100644
--- a/bfd/elfxx-loongarch.c
+++ b/bfd/elfxx-loongarch.c
@@ -1629,9 +1629,6 @@ loongarch_larch_reloc_name_lookup (bfd *abfd ATTRIBUTE_UNUSED,
return lht->bfd_type;
}
- (*_bfd_error_handler) (_("%pB: unsupported relocation type name %s"),
- abfd, l_r_name);
- bfd_set_error (bfd_error_bad_value);
return BFD_RELOC_NONE;
}
diff --git a/gas/config/loongarch-parse.y b/gas/config/loongarch-parse.y
index f4e1a63b972..f786fdaee5f 100644
--- a/gas/config/loongarch-parse.y
+++ b/gas/config/loongarch-parse.y
@@ -132,7 +132,11 @@ reloc (const char *op_c_str, const char *id_c_str, offsetT addend)
if (0 == strcmp (op_c_str, "plt"))
btype = BFD_RELOC_LARCH_B26;
else
- btype = loongarch_larch_reloc_name_lookup (NULL, op_c_str);
+ {
+ btype = loongarch_larch_reloc_name_lookup (NULL, op_c_str);
+ if (btype == BFD_RELOC_NONE)
+ as_fatal (_("unsupported modifier %s"), op_c_str);
+ }
if (id_c_str)
{
diff --git a/gas/testsuite/gas/loongarch/reloc_type.d b/gas/testsuite/gas/loongarch/reloc_type.d
new file mode 100644
index 00000000000..0a8f77825a0
--- /dev/null
+++ b/gas/testsuite/gas/loongarch/reloc_type.d
@@ -0,0 +1,3 @@
+#as:
+#source: reloc_type.s
+#error_output: reloc_type.l
diff --git a/gas/testsuite/gas/loongarch/reloc_type.l b/gas/testsuite/gas/loongarch/reloc_type.l
new file mode 100644
index 00000000000..e981f6f2aa5
--- /dev/null
+++ b/gas/testsuite/gas/loongarch/reloc_type.l
@@ -0,0 +1,2 @@
+.*Assembler messages:
+.*Fatal error: unsupported modifier (.*)$
diff --git a/gas/testsuite/gas/loongarch/reloc_type.s b/gas/testsuite/gas/loongarch/reloc_type.s
new file mode 100644
index 00000000000..2ce277779db
--- /dev/null
+++ b/gas/testsuite/gas/loongarch/reloc_type.s
@@ -0,0 +1,3 @@
+.L1:
+ nop
+ addi.d $a0,$a1,%reloc(x)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-11-22 6:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-22 6:43 [binutils-gdb] LoongArch: fix internal error when as handling unsupported modifier liu & zhensong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).