From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1147) id 4B1133858D32; Thu, 30 Nov 2023 09:15:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B1133858D32 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Rainer Orth To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org Subject: [binutils-gdb] libiberty: Disable hwcaps for sha1.o X-Act-Checkin: binutils-gdb X-Git-Author: Rainer Orth X-Git-Refname: refs/heads/master X-Git-Oldrev: 460e0e6e3e6c23ed5f4b70e1b86435f58cb890aa X-Git-Newrev: 56006f79386f261f637809296585153b09f84ee1 Message-Id: <20231130091511.4B1133858D32@sourceware.org> Date: Thu, 30 Nov 2023 09:15:11 +0000 (GMT) X-BeenThere: binutils-cvs@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2023 09:15:11 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D56006f79386f= 261f637809296585153b09f84ee1 commit 56006f79386f261f637809296585153b09f84ee1 Author: Rainer Orth Date: Thu Nov 30 10:14:30 2023 +0100 libiberty: Disable hwcaps for sha1.o =20 This patch =20 commit bf4f40cc3195eb7b900bf5535cdba1ee51fdbb8e Author: Jakub Jelinek Date: Tue Nov 28 13:14:05 2023 +0100 =20 libiberty: Use x86 HW optimized sha1 =20 broke Solaris/x86 bootstrap with the native as: =20 libtool: compile: /var/gcc/regression/master/11.4-gcc/build/./gcc/gccg= o -B/var/gcc/regression/master/11.4-gcc/build/./gcc/ -B/vol/gcc/i386-pc-sol= aris2.11/bin/ -B/vol/gcc/i386-pc-solaris2.11/lib/ -isystem /vol/gcc/i386-pc= -solaris2.11/include -isystem /vol/gcc/i386-pc-solaris2.11/sys-include -fch= ecking=3D1 -minline-all-stringops -O2 -g -I . -c -fgo-pkgpath=3Dinternal/go= arch /vol/gcc/src/hg/master/local/libgo/go/internal/goarch/goarch.go zgoarc= h.go ld.so.1: go1: fatal: /var/gcc/regression/master/11.4-gcc/build/gcc/go1:= hardware capability (CA_SUNW_HW_2) unsupported: 0x4000000 [ SHA1 ] gccgo: fatal error: Killed signal terminated program go1 =20 As is already done in a couple of other similar cases, this patches disables hwcaps support for libiberty. =20 Initially, this didn't work because config/hwcaps.m4 uses target_os, but didn't ensure it is defined. =20 Tested on i386-pc-solaris2.11 with as and gas. =20 2023-11-29 Rainer Orth =20 config: * hwcaps.m4 (GCC_CHECK_ASSEMBLER_HWCAP): Require AC_CANONICAL_TARGET. =20 libiberty: * configure.ac (GCC_CHECK_ASSEMBLER_HWCAP): Invoke. * configure, aclocal.m4: Regenerate. * Makefile.in (COMPILE.c): Add HWCAP_CFLAGS. Diff: --- config/ChangeLog | 5 +++ config/hwcaps.m4 | 1 + libiberty/ChangeLog | 6 ++++ libiberty/Makefile.in | 2 +- libiberty/aclocal.m4 | 2 ++ libiberty/configure | 91 ++++++++++++++++++++++++++++++++++++++++++++++= ++++ libiberty/configure.ac | 2 ++ 7 files changed, 108 insertions(+), 1 deletion(-) diff --git a/config/ChangeLog b/config/ChangeLog index bb82cc873ea..b8943c95cad 100644 --- a/config/ChangeLog +++ b/config/ChangeLog @@ -1,3 +1,8 @@ +2023-11-30 Rainer Orth + + * hwcaps.m4 (GCC_CHECK_ASSEMBLER_HWCAP): Require + AC_CANONICAL_TARGET. + 2023-11-15 Arsen Arsenovi=C4=87 =20 * intlmacosx.m4: Import from gettext-0.22 (serial 8). diff --git a/config/hwcaps.m4 b/config/hwcaps.m4 index ff352fdd3a6..33f090574cf 100644 --- a/config/hwcaps.m4 +++ b/config/hwcaps.m4 @@ -7,6 +7,7 @@ dnl HWCAP_CFLAGS=3D'-Wa,-nH' if possible. dnl AC_DEFUN([GCC_CHECK_ASSEMBLER_HWCAP], [ test -z "$HWCAP_CFLAGS" && HWCAP_CFLAGS=3D'' + AC_REQUIRE([AC_CANONICAL_TARGET]) =20 # Restrict the test to Solaris, other assemblers (e.g. AIX as) have -nH # with a different meaning. diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog index a8fdc1b8f0e..3258d1a46f4 100644 --- a/libiberty/ChangeLog +++ b/libiberty/ChangeLog @@ -1,3 +1,9 @@ +2023-11-30 Rainer Orth + + * configure.ac (GCC_CHECK_ASSEMBLER_HWCAP): Invoke. + * configure, aclocal.m4: Regenerate. + * Makefile.in (COMPILE.c): Add HWCAP_CFLAGS. + 2023-11-28 Jakub Jelinek =20 * configure.ac (HAVE_X86_SHA1_HW_SUPPORT): New check. diff --git a/libiberty/Makefile.in b/libiberty/Makefile.in index f9fbba23e2c..d7e2d79f047 100644 --- a/libiberty/Makefile.in +++ b/libiberty/Makefile.in @@ -114,7 +114,7 @@ INCDIR=3D$(srcdir)/$(MULTISRCTOP)../include =20 COMPILE.c =3D $(CC) -c @DEFS@ $(CFLAGS) $(CPPFLAGS) -I. -I$(INCDIR) \ $(HDEFINES) @ac_libiberty_warn_cflags@ -D_GNU_SOURCE \ - @CET_HOST_FLAGS@ + @CET_HOST_FLAGS@ @HWCAP_CFLAGS@ =20 # Just to make sure we don't use a built-in rule with VPATH .c.$(objext): diff --git a/libiberty/aclocal.m4 b/libiberty/aclocal.m4 index 0757688d52a..364fb6bc3b4 100644 --- a/libiberty/aclocal.m4 +++ b/libiberty/aclocal.m4 @@ -16,7 +16,9 @@ m4_include([../config/acx.m4]) m4_include([../config/cet.m4]) m4_include([../config/enable.m4]) m4_include([../config/gcc-plugin.m4]) +m4_include([../config/hwcaps.m4]) m4_include([../config/no-executables.m4]) +m4_include([../config/override.m4]) m4_include([../config/picflag.m4]) m4_include([../config/warnings.m4]) m4_include([acinclude.m4]) diff --git a/libiberty/configure b/libiberty/configure index 9cdf802539e..d39b1b71233 100755 --- a/libiberty/configure +++ b/libiberty/configure @@ -626,6 +626,11 @@ pexecute target_header_dir CHECK LIBOBJS +HWCAP_CFLAGS +target_os +target_vendor +target_cpu +target CET_HOST_FLAGS NOASANFLAG PICFLAG @@ -1325,6 +1330,7 @@ _ACEOF System types: --build=3DBUILD configure for building on BUILD [guessed] --host=3DHOST cross-compile to build programs to run on HOST [BUIL= D] + --target=3DTARGET configure for building compilers for TARGET [HOST] _ACEOF fi =20 @@ -2462,6 +2468,9 @@ ac_compiler_gnu=3D$ac_cv_c_compiler_gnu =20 =20 =20 + + + # This works around the fact that libtool configuration may change LD # for this particular configuration, but some shells, instead of # keeping the changes in LD private, export them just because LD is @@ -5631,6 +5640,88 @@ LDFLAGS=3D"$cet_save_LDFLAGS" =20 =20 =20 +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking target system type" >&5 +$as_echo_n "checking target system type... " >&6; } +if ${ac_cv_target+:} false; then : + $as_echo_n "(cached) " >&6 +else + if test "x$target_alias" =3D x; then + ac_cv_target=3D$ac_cv_host +else + ac_cv_target=3D`$SHELL "$ac_aux_dir/config.sub" $target_alias` || + as_fn_error $? "$SHELL $ac_aux_dir/config.sub $target_alias failed" "$= LINENO" 5 +fi + +fi +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_target" >&5 +$as_echo "$ac_cv_target" >&6; } +case $ac_cv_target in +*-*-*) ;; +*) as_fn_error $? "invalid value of canonical target" "$LINENO" 5;; +esac +target=3D$ac_cv_target +ac_save_IFS=3D$IFS; IFS=3D'-' +set x $ac_cv_target +shift +target_cpu=3D$1 +target_vendor=3D$2 +shift; shift +# Remember, the first character of IFS is used to create $*, +# except with old shells: +target_os=3D$* +IFS=3D$ac_save_IFS +case $target_os in *\ *) target_os=3D`echo "$target_os" | sed 's/ /-/g'`;;= esac + + +# The aliases save the names the user supplied, while $host etc. +# will get canonicalized. +test -n "$target_alias" && + test "$program_prefix$program_suffix$program_transform_name" =3D \ + NONENONEs,x,x, && + program_prefix=3D${target_alias}- + + test -z "$HWCAP_CFLAGS" && HWCAP_CFLAGS=3D'' + + + # Restrict the test to Solaris, other assemblers (e.g. AIX as) have -nH + # with a different meaning. + case ${target_os} in + solaris2*) + ac_save_CFLAGS=3D"$CFLAGS" + CFLAGS=3D"$CFLAGS -Wa,-nH" + + { $as_echo "$as_me:${as_lineno-$LINENO}: checking for as that suppor= ts -Wa,-nH" >&5 +$as_echo_n "checking for as that supports -Wa,-nH... " >&6; } + cat confdefs.h - <<_ACEOF >conftest.$ac_ext +/* end confdefs.h. */ + +int +main () +{ +return 0; + ; + return 0; +} +_ACEOF +if ac_fn_c_try_compile "$LINENO"; then : + ac_hwcap_flags=3Dyes +else + ac_hwcap_flags=3Dno +fi +rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext + if test "$ac_hwcap_flags" =3D "yes"; then + HWCAP_CFLAGS=3D"-Wa,-nH $HWCAP_CFLAGS" + fi + { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_hwcap_flags" >&5 +$as_echo "$ac_hwcap_flags" >&6; } + + CFLAGS=3D"$ac_save_CFLAGS" + ;; + esac + + + + echo "# Warning: this fragment is automatically generated" > temp-frag =20 if [ -n "${frag}" ] && [ -f "${frag}" ]; then diff --git a/libiberty/configure.ac b/libiberty/configure.ac index e07cbb8aabf..cf2c9703781 100644 --- a/libiberty/configure.ac +++ b/libiberty/configure.ac @@ -265,6 +265,8 @@ AC_SUBST(NOASANFLAG) GCC_CET_HOST_FLAGS(CET_HOST_FLAGS) AC_SUBST(CET_HOST_FLAGS) =20 +GCC_CHECK_ASSEMBLER_HWCAP + echo "# Warning: this fragment is automatically generated" > temp-frag =20 if [[ -n "${frag}" ]] && [[ -f "${frag}" ]]; then