public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] Fix segmentation fault in bfd/elf32-hppa.c
@ 2023-12-15 21:03 John David Anglin
  0 siblings, 0 replies; only message in thread
From: John David Anglin @ 2023-12-15 21:03 UTC (permalink / raw)
  To: bfd-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fc4ddd6734e522debe7e99812b743b368f1cc946

commit fc4ddd6734e522debe7e99812b743b368f1cc946
Author: John David Anglin <danglin@gcc.gnu.org>
Date:   Fri Dec 15 21:02:32 2023 +0000

    Fix segmentation fault in bfd/elf32-hppa.c
    
    2023-12-15  John David Anglin  <danglin@gcc.gnu.org>
    
            PR ld/31148
    
    bfd/ChangeLog:
    
            * elf32-hppa.c (elf32_hppa_finish_dynamic_symbol): Output
            relative reloc only when eh->root.type is bfd_link_hash_defined
            or bfd_link_hash_defweak.

Diff:
---
 bfd/elf32-hppa.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/bfd/elf32-hppa.c b/bfd/elf32-hppa.c
index 44129c80138..d64ca7528a0 100644
--- a/bfd/elf32-hppa.c
+++ b/bfd/elf32-hppa.c
@@ -4216,7 +4216,9 @@ elf32_hppa_finish_dynamic_symbol (bfd *output_bfd,
 	     file, we just want to emit a RELATIVE reloc.  The entry
 	     in the global offset table will already have been
 	     initialized in the relocate_section function.  */
-	  if (!is_dyn)
+	  if (!is_dyn
+	      && (eh->root.type == bfd_link_hash_defined
+		  || eh->root.type == bfd_link_hash_defweak))
 	    {
 	      rela.r_info = ELF32_R_INFO (0, R_PARISC_DIR32);
 	      rela.r_addend = (eh->root.u.def.value

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-12-15 21:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-15 21:03 [binutils-gdb] Fix segmentation fault in bfd/elf32-hppa.c John David Anglin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).