public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb/binutils-2_41-branch] ld: ld-lib.exp: log failed dump.out contents for debugging
@ 2023-12-20  2:38 Sam James
  0 siblings, 0 replies; only message in thread
From: Sam James @ 2023-12-20  2:38 UTC (permalink / raw)
  To: bfd-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e686a9aeb4900658797ea748088ae6298f5ca159

commit e686a9aeb4900658797ea748088ae6298f5ca159
Author: Sam James <sam@gentoo.org>
Date:   Wed Aug 16 07:21:53 2023 +0100

    ld: ld-lib.exp: log failed dump.out contents for debugging
    
    If we're using dump_prog in a test which fails, log the dump.out contents
    to ld.log to aid debugging.
    
    This avoids needing to ask reporters to manually run e.g. `objdump` commands
    when making bug reports.
    
    PR30722
            * ld/testsuite/lib/ld-lib.exp: Log failed dump.out contents to aid
            debugging.
    
    Approved-by: Nick Clifton <nickc@redhat.com>
    Signed-off-by: Sam James <sam@gentoo.org>
    (cherry picked from commit 646657284f6b62a71a6869826e951b3def4d73a6)

Diff:
---
 ld/testsuite/lib/ld-lib.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ld/testsuite/lib/ld-lib.exp b/ld/testsuite/lib/ld-lib.exp
index 918464069a9..aca303e0728 100644
--- a/ld/testsuite/lib/ld-lib.exp
+++ b/ld/testsuite/lib/ld-lib.exp
@@ -640,7 +640,7 @@ proc run_ld_link_tests { ldtests args } {
 		    remote_upload host "dump.out"
 
 		    if { [regexp_diff "dump.out" "$srcdir/$subdir/$dumpfile"] } then {
-			verbose "output is [file_contents "dump.out"]" 2
+			verbose -log "output is [file_contents "dump.out"]" 2
 			set failed 1
 			remote_file build delete "dump.out"
 			remote_file host delete "dump.out"
@@ -1067,7 +1067,7 @@ proc run_cc_link_tests { ldtests } {
 		    }
 
 		    if { [regexp_diff "dump.out" "$srcdir/$subdir/$dumpfile"] } then {
-			verbose "output is [file_contents "dump.out"]" 2
+			verbose -log "output is [file_contents "dump.out"]" 2
 			set failed 1
 			break
 		    }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-12-20  2:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-20  2:38 [binutils-gdb/binutils-2_41-branch] ld: ld-lib.exp: log failed dump.out contents for debugging Sam James

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).