From: Jan Beulich <jbeulich@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] x86-64: refuse "high" 8-bit regs with .insn and VEX/XOP/EVEX encodings
Date: Fri, 22 Dec 2023 08:37:41 +0000 (GMT) [thread overview]
Message-ID: <20231222083741.74D953858D33@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3e4a511bee874d73f9f749cc8cf3bc748b4d47b5
commit 3e4a511bee874d73f9f749cc8cf3bc748b4d47b5
Author: Jan Beulich <jbeulich@suse.com>
Date: Fri Dec 22 09:34:10 2023 +0100
x86-64: refuse "high" 8-bit regs with .insn and VEX/XOP/EVEX encodings
Much like REX, those encodings - if permitting 8-bit regs at all, i.e.
only starting with APX - permit use of "new" 8-bit registers only. %ah,
%ch, %dh, and %bh cannot be encoded and hence should be rejected.
Permit their use outside of 64-bit code though, as "new" registers
simply don't exist there.
Diff:
---
gas/config/tc-i386.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index 6e2f6e51457..cdd3b55c655 100644
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -11485,6 +11485,16 @@ s_insn (int dummy ATTRIBUTE_UNUSED)
for (j = i.imm_operands; j < i.operands; ++j)
{
+ /* Look for 8-bit operands that use old registers. */
+ if (i.vec_encoding != vex_encoding_default
+ && flag_code == CODE_64BIT
+ && i.types[j].bitfield.class == Reg
+ && i.types[j].bitfield.byte
+ && !(i.op[j].regs->reg_flags & RegRex64)
+ && i.op[j].regs->reg_num > 3)
+ as_bad (_("can't encode register '%s%s' with VEX/XOP/EVEX"),
+ register_prefix, i.op[j].regs->reg_name);
+
i.types[j].bitfield.instance = InstanceNone;
if (operand_type_check (i.types[j], disp))
reply other threads:[~2023-12-22 8:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222083741.74D953858D33@sourceware.org \
--to=jbeulich@sourceware.org \
--cc=bfd-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).