From: Jan Beulich <jbeulich@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] hppa/ELF: fix .text/.data interaction with .previous
Date: Fri, 22 Dec 2023 08:37:51 +0000 (GMT) [thread overview]
Message-ID: <20231222083751.997883858D33@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1124f3d536e5e03c3fd433c41b947fc49674c0cf
commit 1124f3d536e5e03c3fd433c41b947fc49674c0cf
Author: Jan Beulich <jbeulich@suse.com>
Date: Fri Dec 22 09:35:52 2023 +0100
hppa/ELF: fix .text/.data interaction with .previous
For some ELF targets .text/.data are overridden. In that case
obj_elf_{text,data}() need calling, just like .code vectors to that
function for the remaining ELF targets.
While there also hand on the function arguments, even if right now
they're meaningless. This matches what other targets' code does.
Diff:
---
gas/config/tc-hppa.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/gas/config/tc-hppa.c b/gas/config/tc-hppa.c
index 2e5de070b94..aabb1470315 100644
--- a/gas/config/tc-hppa.c
+++ b/gas/config/tc-hppa.c
@@ -6199,7 +6199,7 @@ pa_callinfo (int unused ATTRIBUTE_UNUSED)
label when finished. */
static void
-pa_text (int unused ATTRIBUTE_UNUSED)
+pa_text (int arg)
{
#ifdef OBJ_SOM
current_space = is_defined_space ("$TEXT$");
@@ -6207,21 +6207,32 @@ pa_text (int unused ATTRIBUTE_UNUSED)
= pa_subsegment_to_subspace (current_space->sd_seg, 0);
#endif
- s_text (0);
+#ifdef OBJ_ELF
+ obj_elf_text (arg);
+#else
+ s_text (arg);
+#endif
+
pa_undefine_label ();
}
/* Switch to the data space. As usual delete our label. */
static void
-pa_data (int unused ATTRIBUTE_UNUSED)
+pa_data (int arg)
{
#ifdef OBJ_SOM
current_space = is_defined_space ("$PRIVATE$");
current_subspace
= pa_subsegment_to_subspace (current_space->sd_seg, 0);
#endif
- s_data (0);
+
+#ifdef OBJ_ELF
+ obj_elf_data (arg);
+#else
+ s_data (arg);
+#endif
+
pa_undefine_label ();
}
reply other threads:[~2023-12-22 8:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222083751.997883858D33@sourceware.org \
--to=jbeulich@sourceware.org \
--cc=bfd-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).