public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] hppa/ELF: fix .text/.data interaction with .previous
@ 2023-12-22  8:37 Jan Beulich
  0 siblings, 0 replies; only message in thread
From: Jan Beulich @ 2023-12-22  8:37 UTC (permalink / raw)
  To: bfd-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1124f3d536e5e03c3fd433c41b947fc49674c0cf

commit 1124f3d536e5e03c3fd433c41b947fc49674c0cf
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Dec 22 09:35:52 2023 +0100

    hppa/ELF: fix .text/.data interaction with .previous
    
    For some ELF targets .text/.data are overridden. In that case
    obj_elf_{text,data}() need calling, just like .code vectors to that
    function for the remaining ELF targets.
    
    While there also hand on the function arguments, even if right now
    they're meaningless. This matches what other targets' code does.

Diff:
---
 gas/config/tc-hppa.c | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/gas/config/tc-hppa.c b/gas/config/tc-hppa.c
index 2e5de070b94..aabb1470315 100644
--- a/gas/config/tc-hppa.c
+++ b/gas/config/tc-hppa.c
@@ -6199,7 +6199,7 @@ pa_callinfo (int unused ATTRIBUTE_UNUSED)
    label when finished.  */
 
 static void
-pa_text (int unused ATTRIBUTE_UNUSED)
+pa_text (int arg)
 {
 #ifdef OBJ_SOM
   current_space = is_defined_space ("$TEXT$");
@@ -6207,21 +6207,32 @@ pa_text (int unused ATTRIBUTE_UNUSED)
     = pa_subsegment_to_subspace (current_space->sd_seg, 0);
 #endif
 
-  s_text (0);
+#ifdef OBJ_ELF
+  obj_elf_text (arg);
+#else
+  s_text (arg);
+#endif
+
   pa_undefine_label ();
 }
 
 /* Switch to the data space.  As usual delete our label.  */
 
 static void
-pa_data (int unused ATTRIBUTE_UNUSED)
+pa_data (int arg)
 {
 #ifdef OBJ_SOM
   current_space = is_defined_space ("$PRIVATE$");
   current_subspace
     = pa_subsegment_to_subspace (current_space->sd_seg, 0);
 #endif
-  s_data (0);
+
+#ifdef OBJ_ELF
+  obj_elf_data (arg);
+#else
+  s_data (arg);
+#endif
+
   pa_undefine_label ();
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-12-22  8:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-22  8:37 [binutils-gdb] hppa/ELF: fix .text/.data interaction with .previous Jan Beulich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).