public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: H.J. Lu <hjl@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] x86: Don't use .insn with '/'
Date: Fri, 29 Dec 2023 23:50:59 +0000 (GMT)	[thread overview]
Message-ID: <20231229235059.6B7463858413@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2eda6e3ecdd0ea93586a532d9464e430f708334a

commit 2eda6e3ecdd0ea93586a532d9464e430f708334a
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Dec 29 15:43:07 2023 -0800

    x86: Don't use .insn with '/'
    
    '/' starts a comment for some targets.  Use .byte instead of .insn with
    '/'.
    
            * testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s: Use .byte
            instead of .insn with '/'.

Diff:
---
 gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
index fde6736e9b2..61ed8824428 100644
--- a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
+++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
@@ -39,11 +39,11 @@ _start:
 	.insn EVEX.L0.NP.0f38.W1 0xf5, %rax, (%rax,%rbx){1to8}, %rcx
 
 	#{evex} inc %rax %rbx EVEX.vvvv != 1111 && EVEX.ND = 0.
-	.insn EVEX.L0.NP.M4.W1 0xff/0, (%rax,%rcx), %rbx
+	.byte 0x62, 0xf4, 0xe4, 0x08, 0xff, 0x04, 0x08
 	# pop2 %rax, %r8 set EVEX.ND=0.
-	.insn EVEX.L0.M4.W0 0x8f/0,  %rax, %r8
+	.byte 0x62, 0xf4, 0x3c, 0x08, 0x8f, 0xc0
 	.byte 0xff, 0xff, 0xff
 	# pop2 %rax, %r8 set EVEX.vvvv = 1111.
 	.insn EVEX.L0.M4.W0 0x8f,  %rax, {rn-sae},%r8
 	# pop2 %r8, %r8.
-	.insn EVEX.L0.M4.W0 0x8f/0,  %r8,{rn-sae}, %r8
+	.byte 0x62, 0xd4, 0x3c, 0x18, 0x8f, 0xc0

                 reply	other threads:[~2023-12-29 23:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231229235059.6B7463858413@sourceware.org \
    --to=hjl@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).