public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Michael Frysinger <vapier@sourceware.org>
To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org
Subject: [binutils-gdb] cpu: or1k: drop unused l.swa flag
Date: Mon,  1 Jan 2024 15:52:34 +0000 (GMT)	[thread overview]
Message-ID: <20240101155234.76AC83858C2F@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fa99355b567e0693fb9b09bf328e0d1111e713c0

commit fa99355b567e0693fb9b09bf328e0d1111e713c0
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Mon Dec 18 20:55:58 2023 -0500

    cpu: or1k: drop unused l.swa flag
    
    The "flag" argument isn't set/used in this insn, so drop it.
    This fixes an unused variable warning in the generated sim.

Diff:
---
 cpu/or1korbis.cpu     | 2 +-
 sim/or1k/sem-switch.c | 1 -
 sim/or1k/sem.c        | 1 -
 3 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/cpu/or1korbis.cpu b/cpu/or1korbis.cpu
index a8002a37185..b4ecb84ab41 100644
--- a/cpu/or1korbis.cpu
+++ b/cpu/or1korbis.cpu
@@ -717,7 +717,7 @@
      ((MACH ORBIS-MACHS))
      "l.swa ${simm16-split}($rA),$rB"
      (+ OPC_SWA rA rB simm16)
-     (sequence ((SI addr) (BI flag))
+     (sequence ((SI addr))
 	       (set addr (load-store-addr rA simm16-split 4))
 	       (set sys-sr-f (and atomic-reserve (eq addr atomic-address)))
 	       (if sys-sr-f
diff --git a/sim/or1k/sem-switch.c b/sim/or1k/sem-switch.c
index b63add8817b..dccc65a0ec1 100644
--- a/sim/or1k/sem-switch.c
+++ b/sim/or1k/sem-switch.c
@@ -1056,7 +1056,6 @@ if (EQSI (ANDSI (tmp_addr, 268435452), CPU (h_atomic_address))) {
 
 {
   SI tmp_addr;
-  BI tmp_flag;
   tmp_addr = or1k32bf_make_load_store_addr (current_cpu, GET_H_GPR (FLD (f_r2)), EXTSISI (FLD (f_simm16_split)), 4);
   {
     USI opval = ANDBI (CPU (h_atomic_reserve), EQSI (tmp_addr, CPU (h_atomic_address)));
diff --git a/sim/or1k/sem.c b/sim/or1k/sem.c
index 95c474dc478..973590d4115 100644
--- a/sim/or1k/sem.c
+++ b/sim/or1k/sem.c
@@ -933,7 +933,6 @@ SEM_FN_NAME (or1k32bf,l_swa) (SIM_CPU *current_cpu, SEM_ARG sem_arg)
 
 {
   SI tmp_addr;
-  BI tmp_flag;
   tmp_addr = or1k32bf_make_load_store_addr (current_cpu, GET_H_GPR (FLD (f_r2)), EXTSISI (FLD (f_simm16_split)), 4);
   {
     USI opval = ANDBI (CPU (h_atomic_reserve), EQSI (tmp_addr, CPU (h_atomic_address)));

                 reply	other threads:[~2024-01-01 15:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240101155234.76AC83858C2F@sourceware.org \
    --to=vapier@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).