From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1386) id 2849C385B535; Fri, 5 Jan 2024 07:07:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2849C385B535 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Jan Beulich To: bfd-cvs@sourceware.org Subject: [binutils-gdb] Arm: drop .bss override X-Act-Checkin: binutils-gdb X-Git-Author: Jan Beulich X-Git-Refname: refs/heads/master X-Git-Oldrev: 941d02eaae0557c80c9e4130478e584a8b284494 X-Git-Newrev: c621dd904ff6378bb1e97911b5b526bf0a80e345 Message-Id: <20240105070707.2849C385B535@sourceware.org> Date: Fri, 5 Jan 2024 07:07:07 +0000 (GMT) X-BeenThere: binutils-cvs@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2024 07:07:07 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dc621dd904ff6= 378bb1e97911b5b526bf0a80e345 commit c621dd904ff6378bb1e97911b5b526bf0a80e345 Author: Jan Beulich Date: Fri Jan 5 08:04:18 2024 +0100 Arm: drop .bss override =20 The comment looks bogus (perhaps simply stale), and there are also no other precautions against subsections being used on ELF with .bss. It also doesn't look to be a good idea to override the custom handlers that ELF and COFF have (afaict doing so further broke .previous on ELF). Diff: --- gas/config/tc-arm.c | 16 +--------------- gas/doc/c-arm.texi | 5 ----- 2 files changed, 1 insertion(+), 20 deletions(-) diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c index 74fd50cb9b3..228e5e07eba 100644 --- a/gas/config/tc-arm.c +++ b/gas/config/tc-arm.c @@ -3347,20 +3347,7 @@ s_syntax (int unused ATTRIBUTE_UNUSED) demand_empty_rest_of_line (); } =20 -/* Directives: sectioning and alignment. */ - -static void -s_bss (int ignore ATTRIBUTE_UNUSED) -{ - /* We don't support putting frags in the BSS segment, we fake it by - marking in_bss, then looking at s_skip for clues. */ - subseg_set (bss_section, 0); - demand_empty_rest_of_line (); - -#ifdef md_elf_section_change_hook - md_elf_section_change_hook (); -#endif -} +/* Directives: alignment. */ =20 static void s_even (int ignore ATTRIBUTE_UNUSED) @@ -5187,7 +5174,6 @@ const pseudo_typeS md_pseudo_table[] =3D { "dn", s_dn, 0 }, { "qn", s_qn, 0 }, { "unreq", s_unreq, 0 }, - { "bss", s_bss, 0 }, { "align", s_align_ptwo, 2 }, { "arm", s_arm, 0 }, { "thumb", s_thumb, 0 }, diff --git a/gas/doc/c-arm.texi b/gas/doc/c-arm.texi index de712eddb64..5a951a88220 100644 --- a/gas/doc/c-arm.texi +++ b/gas/doc/c-arm.texi @@ -892,11 +892,6 @@ incrementally to the architecture being compiled for. This performs the same action as @var{.code 32}. =20 @c BBBBBBBBBBBBBBBBBBBBBBBBBB - -@cindex @code{.bss} directive, ARM -@item .bss -This directive switches to the @code{.bss} section. - @c CCCCCCCCCCCCCCCCCCCCCCCCCC =20 @cindex @code{.cantunwind} directive, ARM