public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@sourceware.org>
To: bfd-cvs@sourceware.org
Subject: [binutils-gdb] visium: drop .bss and .skip overrides
Date: Fri,  5 Jan 2024 07:17:48 +0000 (GMT)	[thread overview]
Message-ID: <20240105071748.11AC8385771D@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1ca08a72955dba234586f3cc236be1b343da01b2

commit 1ca08a72955dba234586f3cc236be1b343da01b2
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Jan 5 08:11:43 2024 +0100

    visium: drop .bss and .skip overrides
    
    The comment in s_bss() looks bogus (perhaps simply stale, or wrongly
    copied from another target). It also doesn't look to be a good idea to
    override the custom handler that ELF has (afaict doing so broke
    .previous as well as sub-section specification).
    
    The override for .skip is simply pointless, for read.c having exactly
    the same.
    
    While there also drop two adjacent redundant (with read.h) declarations
    (which would be outright dangerous if read.h wasn't included anyway).

Diff:
---
 gas/config/tc-visium.c | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/gas/config/tc-visium.c b/gas/config/tc-visium.c
index 8c778427b36..ee20be405da 100644
--- a/gas/config/tc-visium.c
+++ b/gas/config/tc-visium.c
@@ -163,40 +163,19 @@ tc_gen_reloc (asection *section ATTRIBUTE_UNUSED, fixS *fixp)
   return reloc;
 }
 
-extern char *input_line_pointer;
-
-
-static void s_bss (int);
 static void visium_rdata (int);
 
 static void visium_update_parity_bit (char *);
 static char *parse_exp (char *, expressionS *);
 
-/* These are the back-ends for the various machine dependent pseudo-ops.  */
-void demand_empty_rest_of_line (void);
-
-
-static void
-s_bss (int ignore ATTRIBUTE_UNUSED)
-{
-  /* We don't support putting frags in the BSS segment, we fake it
-     by marking in_bss, then looking at s_skip for clues.  */
-
-  subseg_set (bss_section, 0);
-  demand_empty_rest_of_line ();
-}
-
-
 /* This table describes all the machine specific pseudo-ops the assembler
-   has to support. The fields are:
+   has to support, and that aren't handled elsewhere. The fields are:
 
    1: Pseudo-op name without dot.
    2: Function to call to execute this pseudo-op.
    3: Integer arg to pass to the function.  */
 const pseudo_typeS md_pseudo_table[] =
 {
-  {"bss", s_bss, 0},
-  {"skip", s_space, 0},
   {"align", s_align_bytes, 0},
   {"noopt", s_ignore, 0},
   {"optim", s_ignore, 0},

                 reply	other threads:[~2024-01-05  7:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240105071748.11AC8385771D@sourceware.org \
    --to=jbeulich@sourceware.org \
    --cc=bfd-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).