public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@sourceware.org>
To: binutils-cvs@sourceware.org
Subject: [binutils-gdb] gas: drop dead check for double quote
Date: Thu, 28 Mar 2024 10:56:06 +0000 (GMT)	[thread overview]
Message-ID: <20240328105606.974693858D20@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=09be89098e3a85785429130030842d4ab11e57e5

commit 09be89098e3a85785429130030842d4ab11e57e5
Author: Jan Beulich <jbeulich@suse.com>
Date:   Thu Mar 28 11:54:25 2024 +0100

    gas: drop dead check for double quote
    
    FB and dollar label definitions can't be enclosed in double quotes. In
    fact at that point nul_char is the same as next_char, which we know is a
    digit.

Diff:
---
 gas/read.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gas/read.c b/gas/read.c
index 61a3f172674..8026a6cdb65 100644
--- a/gas/read.c
+++ b/gas/read.c
@@ -1262,9 +1262,6 @@ read_a_source_file (const char *name)
 
 	      temp = next_char - '0';
 
-	      if (nul_char == '"')
-		++ input_line_pointer;
-
 	      /* Read the whole number.  */
 	      while (ISDIGIT (*input_line_pointer))
 		{

                 reply	other threads:[~2024-03-28 10:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240328105606.974693858D20@sourceware.org \
    --to=jbeulich@sourceware.org \
    --cc=binutils-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).