From: Tom Tromey <tromey@sourceware.org>
To: binutils-cvs@sourceware.org, gdb-cvs@sourceware.org
Subject: [binutils-gdb] Add flake8 and isort to .pre-commit-config.yaml
Date: Thu, 4 Apr 2024 12:43:58 +0000 (GMT) [thread overview]
Message-ID: <20240404124358.6F7073858C98@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=16810e455feb26ef826a3ed876d6d7e6d24818b0
commit 16810e455feb26ef826a3ed876d6d7e6d24818b0
Author: Tom Tromey <tromey@adacore.com>
Date: Tue Apr 2 12:04:21 2024 -0600
Add flake8 and isort to .pre-commit-config.yaml
This adds flake8 and isort to .pre-commit-config.yaml. This way, they
will automatically be run on commit.
I chose the most recent available versions after verifying that they
don't cause any reports or changes in the current tree.
Internally at AdaCore, we also use a few flake8 plugins as well, so
perhaps that's another avenue for investigation.
v2: Also update the various file-selection clauses to pick up
gdb-gdb.py.in; include the isort change made to this file; and finally
add a comment about the exclusions from flake8.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Diff:
---
.pre-commit-config.yaml | 18 +++++++++++++++++-
gdb/gdb-gdb.py.in | 3 ++-
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 7afe60c20be..8721dac678b 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -5,4 +5,20 @@ repos:
rev: 24.3.0
hooks:
- id: black
- files: 'gdb/.*'
+ types_or: [file]
+ files: 'gdb/.*\.py(\.in)?$'
+ - repo: https://github.com/pycqa/flake8
+ rev: 7.0.0
+ hooks:
+ - id: flake8
+ types_or: [file]
+ # Note this one is only run on gdb/python, not (for now) the
+ # test suite.
+ files: 'gdb/python/.*\.py(\.in)?$'
+ args: [--config, gdb/setup.cfg]
+ - repo: https://github.com/pycqa/isort
+ rev: 5.13.2
+ hooks:
+ - id: isort
+ types_or: [file]
+ files: 'gdb/.*\.py(\.in)?$'
diff --git a/gdb/gdb-gdb.py.in b/gdb/gdb-gdb.py.in
index 54db9b00cf3..b5a7fa4f390 100644
--- a/gdb/gdb-gdb.py.in
+++ b/gdb/gdb-gdb.py.in
@@ -15,9 +15,10 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-import gdb
import os.path
+import gdb
+
class TypeFlag:
"""A class that allows us to store a flag name, its short name,
reply other threads:[~2024-04-04 12:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240404124358.6F7073858C98@sourceware.org \
--to=tromey@sourceware.org \
--cc=binutils-cvs@sourceware.org \
--cc=gdb-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).