From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1062) id C5A4A3858282; Tue, 9 Apr 2024 02:00:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C5A4A3858282 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1712628033; bh=AHRe6Tzg8cf5/eoqEX/EpEbf7L6Xp0seZjGTd3LzEtc=; h=From:To:Subject:Date:From; b=VE8pWOBGyVFdgMkEib9e0zr/sxW7Osu61PRJCA65n3yPuu9JuEovGEpZlXWerm85L Umf8sYhUMk+moL1CYehPWSZwMiS048tfP08S/myeyRKA7zQU9aYpTZ7iSnkpvMru94 FTZfuBcXhOJLQ8CBW1mFj/Mx1lNivU/K2tXczaEY= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Alan Modra To: binutils-cvs@sourceware.org Subject: [binutils-gdb] Remove dead code in bfdwin.c X-Act-Checkin: binutils-gdb X-Git-Author: Alan Modra X-Git-Refname: refs/heads/master X-Git-Oldrev: c8d45dbd0a05885f57e52f9b852bea4c84bf3062 X-Git-Newrev: 7c71e67e119eb36f62803797640b7638bac6d5e8 Message-Id: <20240409020033.C5A4A3858282@sourceware.org> Date: Tue, 9 Apr 2024 02:00:33 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D7c71e67e119e= b36f62803797640b7638bac6d5e8 commit 7c71e67e119eb36f62803797640b7638bac6d5e8 Author: Alan Modra Date: Tue Apr 9 08:50:23 2024 +0930 Remove dead code in bfdwin.c =20 All of bfdwin.c is wrapped in USE_MMAP. There isn't any point in HAVE_MMAP tests inside USE_MMAP. =20 * bfdwin.c (bfd_free_window, bfd_get_file_window): Delete HAVE_MMAP conditionals. Diff: --- bfd/bfdwin.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/bfd/bfdwin.c b/bfd/bfdwin.c index 73e44635bcb..0ef7b1418b9 100644 --- a/bfd/bfdwin.c +++ b/bfd/bfdwin.c @@ -118,20 +118,14 @@ bfd_free_window (bfd_window *windowp) =20 if (i->mapped) { -#ifdef HAVE_MMAP munmap (i->data, i->size); goto no_free; -#else - abort (); -#endif } #ifdef HAVE_MPROTECT mprotect (i->data, i->size, PROT_READ | PROT_WRITE); #endif free (i->data); -#ifdef HAVE_MMAP no_free: -#endif i->data =3D 0; /* There should be no more references to i at this point. */ free (i); @@ -174,7 +168,6 @@ bfd_get_file_window (bfd *abfd, return false; i->data =3D NULL; } -#ifdef HAVE_MMAP if (ok_to_map && (i->data =3D=3D NULL || i->mapped =3D=3D 1) && (abfd->flags & BFD_IN_MEMORY) =3D=3D 0) @@ -249,9 +242,6 @@ bfd_get_file_window (bfd *abfd, else fprintf (stderr, _("not mapping: env var not set\n")); } -#else - ok_to_map =3D 0; -#endif =20 #ifdef HAVE_MPROTECT if (!writable)