From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1062) id 7B46B385840B; Wed, 10 Apr 2024 05:54:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7B46B385840B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1712728472; bh=sy9t4cE5jU+QRntAg7DsV9K3RjvtoALb7ny/nCvtI8o=; h=From:To:Subject:Date:From; b=epieteiU9/HxDHOF7PHM9411VVn0M1F8xgfACkk8VAAOScwrdQMHSHEETuJNZ4cZd drhwHENXuslOkb0BuaTXZ+h8Ibj4+z394y+WQ8riocvhwDr86qexw8O9xJX5C4gOdf qkWAfAb5WmATwFJAcXg99H8813EFI2Zmx/lxcpL0= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Alan Modra To: binutils-cvs@sourceware.org Subject: [binutils-gdb] Re: ld testsuite: Append NOSANITIZE_CFLAGS to CFLAGS_FOR_TARGET X-Act-Checkin: binutils-gdb X-Git-Author: Alan Modra X-Git-Refname: refs/heads/master X-Git-Oldrev: 2c8dd9b1c312f8e02b83e8064d80eac617356532 X-Git-Newrev: bdefc073061ff9e9334a1306e9c70745104dc57f Message-Id: <20240410055432.7B46B385840B@sourceware.org> Date: Wed, 10 Apr 2024 05:54:32 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dbdefc073061f= f9e9334a1306e9c70745104dc57f commit bdefc073061ff9e9334a1306e9c70745104dc57f Author: Alan Modra Date: Wed Apr 10 09:27:44 2024 +0930 Re: ld testsuite: Append NOSANITIZE_CFLAGS to CFLAGS_FOR_TARGET =20 Don't use CC_FOR_TARGET in the bootstrap test, a silly idea aiming at consistency that made things worse. The objects being linked were built using $CC, so $CC should be used to link. =20 * testsuite/ld-bootstrap/bootstrap.exp: Revert last change. Diff: --- ld/testsuite/ld-bootstrap/bootstrap.exp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ld/testsuite/ld-bootstrap/bootstrap.exp b/ld/testsuite/ld-boot= strap/bootstrap.exp index 4b19a1283d3..437a3bc6842 100644 --- a/ld/testsuite/ld-bootstrap/bootstrap.exp +++ b/ld/testsuite/ld-bootstrap/bootstrap.exp @@ -190,7 +190,7 @@ foreach flags $test_flags { setup_xfail "mips*-*-irix5*" } =20 - if ![ld_link $CC_FOR_TARGET tmpdir/ld1 "$CFLAGS_FOR_TARGET $flags tmpd= ir/ld-partial.o $CTFLIB $BFDLIB $LIBIBERTY $SFRAMELIB $extralibs"] { + if ![ld_link $CC tmpdir/ld1 "$CFLAGS $flags tmpdir/ld-partial.o $CTFLI= B $BFDLIB $LIBIBERTY $SFRAMELIB $extralibs"] { fail $testname continue } @@ -207,13 +207,13 @@ foreach flags $test_flags { } =20 regsub /tmpdir/ld/ $gcc_B_opt_save /tmpdir/gccld1/ gcc_B_opt - if ![ld_link $CC_FOR_TARGET tmpdir/ld2 "$CFLAGS_FOR_TARGET $flags $OFI= LES $CTFLIB $BFDLIB $LIBIBERTY $SFRAMELIB $extralibs"] { + if ![ld_link $CC tmpdir/ld2 "$CFLAGS $flags $OFILES $CTFLIB $BFDLIB $L= IBIBERTY $SFRAMELIB $extralibs"] { fail $testname continue } =20 regsub /tmpdir/ld/ $gcc_B_opt_save /tmpdir/gccld2/ gcc_B_opt - if ![ld_link $CC_FOR_TARGET tmpdir/ld3 "$CFLAGS_FOR_TARGET $flags $OFI= LES $CTFLIB $BFDLIB $LIBIBERTY $SFRAMELIB $extralibs"] { + if ![ld_link $CC tmpdir/ld3 "$CFLAGS $flags $OFILES $CTFLIB $BFDLIB $L= IBIBERTY $SFRAMELIB $extralibs"] { fail $testname continue } @@ -226,7 +226,7 @@ foreach flags $test_flags { # generated by different linkers, tmpdir/ld1 and tmpdir/ld2. # So we rebuild tmpdir/ld2 with tmpdir/ld3. regsub /tmpdir/ld/ $gcc_B_opt_save /tmpdir/gccld3/ gcc_B_opt - if ![ld_link $CC_FOR_TARGET tmpdir/ld2 "$CFLAGS_FOR_TARGET $flags $OFILES= $CTFLIB $BFDLIB $LIBIBERTY $SFRAMELIB $extralibs"] { + if ![ld_link $CC tmpdir/ld2 "$CFLAGS $flags $OFILES $CTFLIB $BFDLIB $LIBI= BERTY $SFRAMELIB $extralibs"] { fail $testname continue }