From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1062) id DEE3838708AC; Thu, 11 Apr 2024 00:09:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DEE3838708AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1712794174; bh=sucgLZX+4zo96+LpU4phmiB1ErPhamUqsiJv4UBKQQk=; h=From:To:Subject:Date:From; b=UmNI53ze7Ff0ImqLX2y+0WxhJBc9g+8+S7AV1qhetHCPVw/acRWlczbu5w6W2VKxY zdPKzHkfzsnm7StUhKgazFtI0xibmgcwjBFAja+qI7ABnL22vPWn8LYpMTFNr+Q1tX 2Thnx79a0NHiKubaOVZIlAYg/Zsik6ej2jdZDL3U= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Alan Modra To: binutils-cvs@sourceware.org Subject: [binutils-gdb] Segfault in _bfd_delete_bfd with USE_MMAP X-Act-Checkin: binutils-gdb X-Git-Author: Alan Modra X-Git-Refname: refs/heads/master X-Git-Oldrev: f8e9374ea8c6e85012c377a2780ba2fc3c26f208 X-Git-Newrev: ea3002bc4d2a3c8ad284041f8a7dd08472c3f5fa Message-Id: <20240411000934.DEE3838708AC@sourceware.org> Date: Thu, 11 Apr 2024 00:09:34 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dea3002bc4d2a= 3c8ad284041f8a7dd08472c3f5fa commit ea3002bc4d2a3c8ad284041f8a7dd08472c3f5fa Author: Alan Modra Date: Thu Apr 11 09:25:13 2024 +0930 Segfault in _bfd_delete_bfd with USE_MMAP =20 Any of the calls to _bfd_delete_bfd in bfd_fopen will hit this. =20 * opncls.c (_bfd_delete_bfd): Check for non-NULL xvec before accessing flavour. Diff: --- bfd/opncls.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bfd/opncls.c b/bfd/opncls.c index 2f8a3a6c919..bc76696dfdb 100644 --- a/bfd/opncls.c +++ b/bfd/opncls.c @@ -164,7 +164,8 @@ static void _bfd_delete_bfd (bfd *abfd) { #ifdef USE_MMAP - if (bfd_get_flavour (abfd) =3D=3D bfd_target_elf_flavour) + if (abfd->xvec + && abfd->xvec->flavour =3D=3D bfd_target_elf_flavour) { asection *sec; for (sec =3D abfd->sections; sec !=3D NULL; sec =3D sec->next)