From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1039) id 7DEB0384AB49; Thu, 11 Apr 2024 11:11:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7DEB0384AB49 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1712833884; bh=4zdn+6ZirHOtpVEqWKnYjvNI87KoA8gfwo07wvo3dSw=; h=From:To:Subject:Date:From; b=aLazNuN7HVWxkFSg9Gqfqemii4dPZzEB+2fb2WWGb+DHCc+nUSWd2wq611jKLjIS9 jsqRYiP0ORBzzeV59wLrKqUIaSTS5AepKtBm6MLJ4dPm1lJvAJsTPcCje6FKMCmT/T bXZsg76iY42nRZNBkCdNaRNzB/w+TEQqZwocmG+M= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: H.J. Lu To: binutils-cvs@sourceware.org Subject: [binutils-gdb] gas: Fix a CFI label name memory leak in scfi.c X-Act-Checkin: binutils-gdb X-Git-Author: H.J. Lu X-Git-Refname: refs/heads/master X-Git-Oldrev: 80ec23548f144e7bdfe2e7e9bcf78279c100d1ee X-Git-Newrev: cafca5eaa068eaaa3e3a2ffab356efb4714c2968 Message-Id: <20240411111124.7DEB0384AB49@sourceware.org> Date: Thu, 11 Apr 2024 11:11:24 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dcafca5eaa068= eaaa3e3a2ffab356efb4714c2968 commit cafca5eaa068eaaa3e3a2ffab356efb4714c2968 Author: H.J. Lu Date: Tue Apr 9 16:04:16 2024 -0700 gas: Fix a CFI label name memory leak in scfi.c =20 CFI label name can be freed only after use. =20 * scfi.c (handle_scfi_dot_cfi): Free CFI label name after use. * scfidw2gen.c (scfi_process_cfi_label): Add a comment. Remove TODO on freeing CFI label name. Diff: --- gas/scfi.c | 1 + gas/scfidw2gen.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/gas/scfi.c b/gas/scfi.c index 929ea8a73e1..b29e922ecb3 100644 --- a/gas/scfi.c +++ b/gas/scfi.c @@ -1141,6 +1141,7 @@ handle_scfi_dot_cfi (ginsnS *ginsn) break; case CFI_label: scfi_dot_cfi (CFI_label, 0, 0, 0, op->op_data->name, ginsn->sym); + free ((char *) op->op_data->name); break; case CFI_signal_frame: scfi_dot_cfi (CFI_signal_frame, 0, 0, 0, NULL, ginsn->sym); diff --git a/gas/scfidw2gen.c b/gas/scfidw2gen.c index ebf2d24dab2..2b018fac8bd 100644 --- a/gas/scfidw2gen.c +++ b/gas/scfidw2gen.c @@ -57,8 +57,8 @@ scfi_process_cfi_label (void) frch_ginsn_data_append (ginsn); =20 scfi_op_add_cfi_label (ginsn, name); - /* TODO. */ - // free (name); + /* NB: Can't free NAME here since it will be used later. Free it in + handle_scfi_dot_cfi after it is unused. */ =20 demand_empty_rest_of_line (); }