public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@sourceware.org>
To: binutils-cvs@sourceware.org
Subject: [binutils-gdb] mmix disassemble memory leak
Date: Fri, 19 Apr 2024 00:33:08 +0000 (GMT)	[thread overview]
Message-ID: <20240419003308.6938D384AB52@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a1defbe4267c73b318f0e0aad82691ef3647cc1f

commit a1defbe4267c73b318f0e0aad82691ef3647cc1f
Author: Alan Modra <amodra@gmail.com>
Date:   Fri Apr 19 09:04:16 2024 +0930

    mmix disassemble memory leak
    
    It's a once-off and of no consequence, but fix it anyway.  The mmix
    caonoicalize_syms array is an array of pointers.  Freeing it won't
    lose symbol names.
    
            * mmix-dis.c (initialize_mmix_dis_info): Free syms.

Diff:
---
 opcodes/mmix-dis.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/opcodes/mmix-dis.c b/opcodes/mmix-dis.c
index ea17bfe974a..370da70ed5d 100644
--- a/opcodes/mmix-dis.c
+++ b/opcodes/mmix-dis.c
@@ -117,6 +117,7 @@ initialize_mmix_dis_info (struct disassemble_info *info)
 		  && minfop->reg_name[syms[i]->value] == NULL)
 		minfop->reg_name[syms[i]->value] = syms[i]->name;
 	    }
+	  free (syms);
 	}
     }

                 reply	other threads:[~2024-04-19  0:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240419003308.6938D384AB52@sourceware.org \
    --to=amodra@sourceware.org \
    --cc=binutils-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).