From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2103) id 763843849AD9; Fri, 19 Apr 2024 15:52:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 763843849AD9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1713541925; bh=KsX4QfAXMVyP0H9X47Y3r/pdamvUEDa6FILPLn8wiAc=; h=From:To:Subject:Date:From; b=k+pIOEuV9BITvabS0MtjAP+xNJ9qnLid4gplLDoitzEjbQBOLX5KoVBjQTf8WnTF5 2Lp6lobwslg4xe5O4C9bFEOMC6gl50QBnFy8+v5Q5C2DUjhdP4pPxZ3lcvqURP+chX B6DIJllZehOXGI4KnUpl07HXH1dzxv3mcGbcFPcM= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Nick Alcock To: binutils-cvs@sourceware.org Subject: [binutils-gdb] libctf: fix tiny dumping error X-Act-Checkin: binutils-gdb X-Git-Author: Nick Alcock X-Git-Refname: refs/heads/master X-Git-Oldrev: 483546ce4f36a93d3fb711f2261b15b75871f3f9 X-Git-Newrev: eb244227d83c81fa17ec2f5ddc933945b14217fd Message-Id: <20240419155205.763843849AD9@sourceware.org> Date: Fri, 19 Apr 2024 15:52:05 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Deb244227d83c= 81fa17ec2f5ddc933945b14217fd commit eb244227d83c81fa17ec2f5ddc933945b14217fd Author: Nick Alcock Date: Tue Apr 2 13:46:53 2024 +0100 libctf: fix tiny dumping error =20 Without this, you might get things like this in the output: =20 Flags: 0xa (CTF_F_NEWFUNCINFO, , CTF_F_DYNSTR) =20 Note the spurious comma. =20 libctf/ * ctf-dump.c (ctf_dump_header): Fix comma emission. Diff: --- libctf/ctf-dump.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libctf/ctf-dump.c b/libctf/ctf-dump.c index 474c4e00cea..2213d09dc29 100644 --- a/libctf/ctf-dump.c +++ b/libctf/ctf-dump.c @@ -333,13 +333,12 @@ ctf_dump_header (ctf_dict_t *fp, ctf_dump_state_t *st= ate) ? ", " : "", fp->ctf_openflags & CTF_F_NEWFUNCINFO ? "CTF_F_NEWFUNCINFO" : "", - (fp->ctf_openflags & (CTF_F_COMPRESS | CTF_F_NEWFUNCINFO)) + (fp->ctf_openflags & (CTF_F_NEWFUNCINFO)) && (fp->ctf_openflags & ~(CTF_F_COMPRESS | CTF_F_NEWFUNCINFO)) ? ", " : "", fp->ctf_openflags & CTF_F_IDXSORTED ? "CTF_F_IDXSORTED" : "", - fp->ctf_openflags & (CTF_F_COMPRESS | CTF_F_NEWFUNCINFO - | CTF_F_IDXSORTED) + fp->ctf_openflags & (CTF_F_IDXSORTED) && (fp->ctf_openflags & ~(CTF_F_COMPRESS | CTF_F_NEWFUNCINFO | CTF_F_IDXSORTED)) ? ", " : "",