public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Nick Alcock <nix@sourceware.org>
To: binutils-cvs@sourceware.org
Subject: [binutils-gdb] libctf: Remove undefined functions from ver. map
Date: Fri, 19 Apr 2024 15:52:41 +0000 (GMT)	[thread overview]
Message-ID: <20240419155241.E0F463849AF4@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d8e1bca7ebc357ebd9b7a338a53d2767cf0564b6

commit d8e1bca7ebc357ebd9b7a338a53d2767cf0564b6
Author: Nicholas Vinson <nvinson234@gmail.com>
Date:   Wed Apr 17 18:52:45 2024 +0100

    libctf: Remove undefined functions from ver. map
    
    Starting with ld.lld-17, ld.lld is invoked with the option
    --no-undefined-version enabled by default. Furthermore, The functions
    ctf_label_set() and ctf_label_get() are not defined. Their inclusion in
    libctf/libctf.ver causes ld.lld-17 to fail emitting the following error
    messages:
    
    ld.lld: error: version script assignment of 'LIBCTF_1.0' to symbol 'ctf_label_set' failed: symbol not defined
    ld.lld: error: version script assignment of 'LIBCTF_1.0' to symbol 'ctf_label_get' failed: symbol not defined
    
    This patch fixes the issue by removing the symbol names from
    libctf/libctf.ver.
    
    [nca: fused in later commit that marked ctf_arc_open as libctf
          only as well.  Added ChangeLog entry.]
    
    Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
    
    libctf/
            * libctf.ver: drop nonexistent label functions: mark
            ctf_arc_open as libctf-only.

Diff:
---
 libctf/libctf.ver | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/libctf/libctf.ver b/libctf/libctf.ver
index c59847d012b..6e7345be66b 100644
--- a/libctf/libctf.ver
+++ b/libctf/libctf.ver
@@ -80,9 +80,6 @@ LIBCTF_1.0 {
 	ctf_enum_name;
 	ctf_enum_value;
 
-	ctf_label_set;
-	ctf_label_get;
-
 	ctf_label_topmost;
 	ctf_label_info;
 
@@ -139,7 +136,6 @@ LIBCTF_1.0 {
 
 	ctf_arc_write;
 	ctf_arc_write_fd;
-	ctf_arc_open;
 	ctf_arc_bufopen;
 	ctf_arc_close;
 	ctf_arc_open_by_name;
@@ -167,6 +163,7 @@ LIBCTF_1.0 {
 
 	ctf_fdopen;                             /* libctf only.  */
 	ctf_open;                               /* libctf only.  */
+	ctf_arc_open;                           /* libctf only.  */
 	ctf_bfdopen;                            /* libctf only.  */
 	ctf_bfdopen_ctfsect;                    /* libctf only.  */
     local:

                 reply	other threads:[~2024-04-19 15:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240419155241.E0F463849AF4@sourceware.org \
    --to=nix@sourceware.org \
    --cc=binutils-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).