From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1062) id 19CE03858C50; Tue, 23 Apr 2024 12:37:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 19CE03858C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1713875870; bh=yubZQAa0u/HAEiJ2AF3BDSOSYW08r2z4uaUC1O6wxuA=; h=From:To:Subject:Date:From; b=wx+oK7RuPQn4iAU51Z35y0v6XHnFuVdExIWzR3AM1Vy02gq9x5H4+dMYs2NXzsD1h eIJmWKp06axs1bPYQGOK6i8AxGZ+eUGfzxFoBnS5kvkZQCMdlfufTZss/Ntoqn1j/x nJ3sFEdSQGmE2AV/06hJmlZxE7F8kczRgXRkdCAs= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Alan Modra To: binutils-cvs@sourceware.org Subject: [binutils-gdb] use copy_private_symbol_data in objcopy X-Act-Checkin: binutils-gdb X-Git-Author: Alan Modra X-Git-Refname: refs/heads/master X-Git-Oldrev: 6705e14a9943e48ccf0f4829a9c23d66b5b83aae X-Git-Newrev: e13e2ba45fe23ec4e6d7335b0834290e61605d4d Message-Id: <20240423123750.19CE03858C50@sourceware.org> Date: Tue, 23 Apr 2024 12:37:50 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3De13e2ba45fe2= 3ec4e6d7335b0834290e61605d4d commit e13e2ba45fe23ec4e6d7335b0834290e61605d4d Author: Alan Modra Date: Mon Apr 22 09:30:38 2024 +0930 use copy_private_symbol_data in objcopy =20 osympp appearing twice here is not a bug. =20 PR 14493 * objcopy.c (copy_object): Run the symbols through bfd_copy_private_symbol_data. Diff: --- binutils/objcopy.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/binutils/objcopy.c b/binutils/objcopy.c index d91ba123c01..634ebae3fc3 100644 --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -3380,6 +3380,13 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_in= fo_type *input_arch) symcount =3D filter_symbols (ibfd, obfd, osympp, isympp, symcount); } =20 + for (i =3D 0; i < symcount; i++) + if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i])) + { + status =3D 1; + return false; + } + if (dhandle !=3D NULL) { bool res;