From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1039) id 7CBB03858417; Tue, 23 Apr 2024 15:38:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7CBB03858417 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1713886699; bh=f/DVQGV9/F3oUBnh3sxZyk08HHQr9Ypc9K0GlKvymJ0=; h=From:To:Subject:Date:From; b=D1xuE5aCmhgs12QAwXcWaCv2K0AUq9FxWSwUUFV6Abd3rqfxTS1M/QfId90k4qsD0 0+BgRS6l0Dn9EylawQ38BUuJLqnDqqxZTx/xyrQHWqFbjdMGY71+pr3TdjB2KnM4KL YMvICrDkG52PR/kuf5jZAifgxO2IEBqbfMmE5oEs= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: H.J. Lu To: binutils-cvs@sourceware.org Subject: [binutils-gdb] objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts X-Act-Checkin: binutils-gdb X-Git-Author: H.J. Lu X-Git-Refname: refs/heads/master X-Git-Oldrev: 9085a018caf2c0f27d85bc9d306a54fe390b99c2 X-Git-Newrev: 6c2119acf78b4a48caa918c1d63aac7a64a19c82 Message-Id: <20240423153819.7CBB03858417@sourceware.org> Date: Tue, 23 Apr 2024 15:38:18 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D6c2119acf78b= 4a48caa918c1d63aac7a64a19c82 commit 6c2119acf78b4a48caa918c1d63aac7a64a19c82 Author: H.J. Lu Date: Tue Apr 23 07:07:51 2024 -0700 objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts =20 Use long with bfd_copy_private_symbol_data to fix =20 .../binutils/objcopy.c: In function =E2=80=98copy_object=E2=80=99: .../binutils/objcopy.c:3383:17: error: comparison of integer expression= s of different signedness: =E2=80=98unsigned int=E2=80=99 and =E2=80=98long= int=E2=80=99 [-Werror=3Dsign-compare] 3383 | for (i =3D 0; i < symcount; i++) | ^ =20 on 32-bit hosts. =20 PR binutils/14493 * objcopy.c (copy_object): Use long with bfd_copy_private_symbol_data. Diff: --- binutils/objcopy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/binutils/objcopy.c b/binutils/objcopy.c index 634ebae3fc3..e8ca1374935 100644 --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -3380,8 +3380,8 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_inf= o_type *input_arch) symcount =3D filter_symbols (ibfd, obfd, osympp, isympp, symcount); } =20 - for (i =3D 0; i < symcount; i++) - if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i])) + for (long s =3D 0; s < symcount; s++) + if (!bfd_copy_private_symbol_data (ibfd, osympp[s], obfd, osympp[s])) { status =3D 1; return false;