From: Alan Modra <amodra@sourceware.org>
To: binutils-cvs@sourceware.org
Subject: [binutils-gdb] buffer overflow in libctf tests
Date: Wed, 24 Apr 2024 01:39:37 +0000 (GMT) [thread overview]
Message-ID: <20240424013937.A4F183861001@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=122f6f14b135480b184091bf2037ea133beedc54
commit 122f6f14b135480b184091bf2037ea133beedc54
Author: Alan Modra <amodra@gmail.com>
Date: Wed Apr 24 09:30:24 2024 +0930
buffer overflow in libctf tests
* testsuite/libctf-regression/gzrewrite.c (main): Don't overflow
"a" buffer in "after adding types" check.
* testsuite/libctf-regression/zrewrite.c (main): Likewise.
Diff:
---
libctf/testsuite/libctf-regression/gzrewrite.c | 2 +-
libctf/testsuite/libctf-regression/zrewrite.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libctf/testsuite/libctf-regression/gzrewrite.c b/libctf/testsuite/libctf-regression/gzrewrite.c
index 99722200950..2e679e85bfe 100644
--- a/libctf/testsuite/libctf-regression/gzrewrite.c
+++ b/libctf/testsuite/libctf-regression/gzrewrite.c
@@ -114,7 +114,7 @@ main (int argc, char *argv[])
if ((b = read_gz ("tmpdir/two.gz", &b_len)) == NULL)
goto read_err;
- if (memcmp (a, b, b_len) == 0)
+ if (a_len == b_len && memcmp (a, b, b_len) == 0)
{
fprintf (stderr, "gzwrites after adding types does not change the dict\n");
return 1;
diff --git a/libctf/testsuite/libctf-regression/zrewrite.c b/libctf/testsuite/libctf-regression/zrewrite.c
index a88c824b568..5e061f10a5f 100644
--- a/libctf/testsuite/libctf-regression/zrewrite.c
+++ b/libctf/testsuite/libctf-regression/zrewrite.c
@@ -109,7 +109,7 @@ main (int argc, char *argv[])
b = read_file ("tmpdir/two", &b_len);
- if (memcmp (a, b, b_len) == 0)
+ if (a_len == b_len && memcmp (a, b, b_len) == 0)
{
fprintf (stderr, "compress_writes after adding types does not change the dict\n");
return 1;
reply other threads:[~2024-04-24 1:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424013937.A4F183861001@sourceware.org \
--to=amodra@sourceware.org \
--cc=binutils-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).