From: Richard Earnshaw <rearnsha@sourceware.org>
To: binutils-cvs@sourceware.org
Subject: [binutils-gdb] arm: fix testsuite fallout on arm-elf and arm-nto from FPA removal
Date: Thu, 6 Jun 2024 15:21:20 +0000 (GMT) [thread overview]
Message-ID: <20240606152120.8587B398BFF8@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=01469ac03e0673d40f8372d5e89139f86327e658
commit 01469ac03e0673d40f8372d5e89139f86327e658
Author: Richard Earnshaw <rearnsha@arm.com>
Date: Thu Jun 6 15:55:16 2024 +0100
arm: fix testsuite fallout on arm-elf and arm-nto from FPA removal
Removing FPA means that in some cases we default to 'no-fpu' in the
assembler when previously we would have picked FPA-format floating
numbers. This patch fixes the testsuite fallout on a couple of
targets that are affected by this change. Where possible we do this
by adding an option to set the floating-point format, but for bad-bss
we just skip the test.
Diff:
---
gas/testsuite/gas/all/gas.exp | 4 +++-
gas/testsuite/gas/arm/float16-eabi-alternative-format.d | 2 +-
gas/testsuite/gas/arm/float16-eabi-ieee-format.d | 2 +-
gas/testsuite/gas/arm/float16-eabi-no-format.d | 1 +
gas/testsuite/gas/elf/bad-bss.d | 1 +
5 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/gas/testsuite/gas/all/gas.exp b/gas/testsuite/gas/all/gas.exp
index af461b1988d..3a922636302 100644
--- a/gas/testsuite/gas/all/gas.exp
+++ b/gas/testsuite/gas/all/gas.exp
@@ -47,7 +47,9 @@ if { ![istarget cris-*-*] && ![istarget crisv32-*-*]
&& ![istarget z80-*-*] } then {
if { [istarget tic4x-*-*] } then {
set as_opt ""
- } elseif { [istarget arm*-*-pe ] } then {
+ } elseif { [istarget arm*-*-pe ]
+ || [istarget arm*-*-elf]
+ || [istarget arm*-*-nto*] } then {
set as_opt "--defsym hasnan=1 -mfpu=softvfp"
} else {
set as_opt "--defsym hasnan=1"
diff --git a/gas/testsuite/gas/arm/float16-eabi-alternative-format.d b/gas/testsuite/gas/arm/float16-eabi-alternative-format.d
index 0729a5ccc21..54636a481ed 100644
--- a/gas/testsuite/gas/arm/float16-eabi-alternative-format.d
+++ b/gas/testsuite/gas/arm/float16-eabi-alternative-format.d
@@ -2,7 +2,7 @@
# readelf: -A
# notarget: *-*pe *-*-wince
# source: float16-eabi.s
-# as: -mfp16-format=alternative
+# as: -mfp16-format=alternative -mfpu=softvfp
Attribute Section: aeabi
File Attributes
Tag_ARM_ISA_use: Yes
diff --git a/gas/testsuite/gas/arm/float16-eabi-ieee-format.d b/gas/testsuite/gas/arm/float16-eabi-ieee-format.d
index d02ed73fb00..7d8412b0a52 100644
--- a/gas/testsuite/gas/arm/float16-eabi-ieee-format.d
+++ b/gas/testsuite/gas/arm/float16-eabi-ieee-format.d
@@ -2,7 +2,7 @@
# readelf: -A
# notarget: *-*pe *-*wince
# source: float16-eabi.s
-# as: -mfp16-format=ieee
+# as: -mfp16-format=ieee -mfpu=softvfp
Attribute Section: aeabi
File Attributes
Tag_ARM_ISA_use: Yes
diff --git a/gas/testsuite/gas/arm/float16-eabi-no-format.d b/gas/testsuite/gas/arm/float16-eabi-no-format.d
index 0d54f844218..706a7475e13 100644
--- a/gas/testsuite/gas/arm/float16-eabi-no-format.d
+++ b/gas/testsuite/gas/arm/float16-eabi-no-format.d
@@ -2,6 +2,7 @@
# readelf: -A
# notarget: *-*pe *-*-wince
# source: float16-eabi.s
+# as: -mfpu=softvfp
Attribute Section: aeabi
File Attributes
Tag_ARM_ISA_use: Yes
diff --git a/gas/testsuite/gas/elf/bad-bss.d b/gas/testsuite/gas/elf/bad-bss.d
index 24a2c620d73..427faf5f03e 100644
--- a/gas/testsuite/gas/elf/bad-bss.d
+++ b/gas/testsuite/gas/elf/bad-bss.d
@@ -1,4 +1,5 @@
#name: bad .bss / .struct data allocation directives
#source: bss.s
#error_output: bad-bss.err
+#notarget: arm*-*-elf arm*-*-nto*
#target: i?86-*-* x86_64-*-* ia64-*-* arm-*-* aarch64-*-* kvx-*-*
reply other threads:[~2024-06-06 15:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606152120.8587B398BFF8@sourceware.org \
--to=rearnsha@sourceware.org \
--cc=binutils-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).