public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@sourceware.org>
To: binutils-cvs@sourceware.org
Subject: [binutils-gdb] Remove srcdir from x86 testcase "source:" lines
Date: Fri, 26 Jul 2024 05:57:05 +0000 (GMT)	[thread overview]
Message-ID: <20240726055705.D48D53858414@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b47de6c86f9836cef0caed02b97d81d3f2560ebf

commit b47de6c86f9836cef0caed02b97d81d3f2560ebf
Author: Alan Modra <amodra@gmail.com>
Date:   Fri Jul 26 15:10:56 2024 +0930

    Remove srcdir from x86 testcase "source:" lines
    
    It's wrong to have ${srcdir} in run_dump_test "source:" lines, as
    run_dump_test adds $srcdir/$subdir/ to the line passed to the shell
    except when the source path starts with "./".  The tests work
    currently because the shell expands ${srcdir} to an empty string.
    
            PR 31728
            * testsuite/ld-i386/code16.d: Correct "source:".
            * testsuite/ld-x86-64/code16.d: Likewise.
            * testsuite/ld-x86-64/rela.d: Likewise.

Diff:
---
 ld/testsuite/ld-i386/code16.d   | 2 +-
 ld/testsuite/ld-x86-64/code16.d | 2 +-
 ld/testsuite/ld-x86-64/rela.d   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ld/testsuite/ld-i386/code16.d b/ld/testsuite/ld-i386/code16.d
index c44fb03b7fb..cca8e8f63c1 100644
--- a/ld/testsuite/ld-i386/code16.d
+++ b/ld/testsuite/ld-i386/code16.d
@@ -1,6 +1,6 @@
 #name: i386 R_386_PC16 reloc in 16-bit mode
 #as: --32 -mx86-used-note=no --generate-missing-build-notes=no
-#source: ${srcdir}/../../../gas/testsuite/gas/i386/code16-2.s
+#source: ../../../gas/testsuite/gas/i386/code16-2.s
 #ld: -T code16.t
 #objdump: -dw -Mi8086
 
diff --git a/ld/testsuite/ld-x86-64/code16.d b/ld/testsuite/ld-x86-64/code16.d
index 5b83681d73c..ff21913b566 100644
--- a/ld/testsuite/ld-x86-64/code16.d
+++ b/ld/testsuite/ld-x86-64/code16.d
@@ -1,6 +1,6 @@
 #name: x86-64 R_X86_64_PC16 reloc in 16-bit mode
 #as: --64 -mx86-used-note=no --generate-missing-build-notes=no
-#source: ${srcdir}/../../../gas/testsuite/gas/i386/code16-2.s
+#source: ../../../gas/testsuite/gas/i386/code16-2.s
 #ld: -T code16.t
 #objdump: -dw -Mi8086
 
diff --git a/ld/testsuite/ld-x86-64/rela.d b/ld/testsuite/ld-x86-64/rela.d
index 20bb7e35232..94bcc7fa6e4 100644
--- a/ld/testsuite/ld-x86-64/rela.d
+++ b/ld/testsuite/ld-x86-64/rela.d
@@ -1,6 +1,6 @@
 #name: x86-64 rela relocs w/ non-zero relocated fields
 #as: --64
-#source: ${srcdir}/../../../gas/testsuite/gas/i386/rela.s
+#source: ../../../gas/testsuite/gas/i386/rela.s
 #ld: -melf_x86_64
 #objdump: -sj .data

                 reply	other threads:[~2024-07-26  5:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240726055705.D48D53858414@sourceware.org \
    --to=amodra@sourceware.org \
    --cc=binutils-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).