RE: [PATCH, ARM, ping2] Add support for value 3 of Tag_ABI_VFP_args attribute

RE: [PATCH, ARM, ping2] Add support for value 3 of Tag_ABI_VFP_args attribute

[Thomas Preud'homme]

Ping?

> -----Original Message-----
> From: binutils-owner@sourceware.org [mailto:binutils-
> owner@sourceware.org] On Behalf Of Thomas Preud'homme
> Sent: Friday, November 28, 2014 3:15 PM
> To: nickc@redhat.com; binutils@sourceware.org
> Subject: RE: [PATCH, ARM, ping1] Add support for value 3 of
> Tag_ABI_VFP_args attribute
> 
> Ping?
> 
> > -----Original Message-----
> > From: binutils-owner@sourceware.org [mailto:binutils-
> > owner@sourceware.org] On Behalf Of Thomas Preud'homme
> > Sent: Thursday, November 13, 2014 9:05 AM
> > To: nickc@redhat.com; binutils@sourceware.org
> > Subject: RE: [PATCH, ARM] Add support for value 3 of
> Tag_ABI_VFP_args
> > attribute
> >
> > Hi Nick,
> >
> > Please find attach a new version of the patch to add support for the
> > value 3
> > of the ARM attribute Tag_ABI_VFP_args with your comment
> addressed.
> >
> > ChangeLog entries are as follows:
> >
> > *** bfd/ChangeLog ***
> >
> > 2014-11-06  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> > 	* elf32-arm.c (elf32_arm_merge_eabi_attributes): Handle new
> > 	Tag_ABI_VFP_args value and replace hardcoded values by enum
> > values.
> > 	(elf32_arm_post_process_headers): Set e_flags in ELF header as
> > hard
> > 	float only when Tag_ABI_VFP_args is 1, using new enum value
> > 	AEABI_VFP_args_vfp to check that.
> >
> >
> > *** binutils/ChangeLog ***
> >
> > 2014-11-03  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> >         * readelf.c (arm_attr_tag_ABI_VFP_args): Add "compatible".
> >
> >
> > *** gdb/ChangeLog ***
> >
> > 2014-11-06  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> > 	* arm-tdep.c (arm_gdbarch_init): Explicitely handle value 3 of
> > 	Tag_ABI_VFP_args. Also replace hardcoded values by enum
> > values in the
> > 	switch handling the different values of Tag_ABI_VFP_args.
> >
> >
> > *** gold/ChangeLog ***
> >
> > 2014-11-06  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> > 	* arm.cc (Target_arm::do_adjust_elf_header): Set e_flags in ELF
> > header
> > 	as hard float only when Tag_ABI_VFP_args is 1, using new enum
> > value
> > 	AEABI_VFP_args_vfp to check that.
> > 	(Target_arm::merge_object_attributes): Handle new
> > Tag_ABI_VFP_args
> > 	value and replace hardcoded values by enum values.
> >
> >
> > *** include/elf/ChangeLog ***
> >
> > 2014-11-03  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> >         * arm.h: New AEABI_FP_number_model_* and
> AEABI_VFP_args_*
> > enum values.
> >
> >
> > *** ld/testsuite/ChangeLog ***
> >
> > 2014-11-03  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> > 	* ld-arm/attr-merge-2a.s: Add Tag_ABI_VFP_args.
> > 	* ld-arm/attr-merge-2b.s: Likewise.
> > 	* ld-arm/attr-merge-2.attr: Likewise.
> > 	* ld-arm/attr-merge-4a.s: Add Tag_ABI_FP_number_model and
> > 	Tag_ABI_VFP_args.
> > 	* ld-arm/attr-merge-4b.s: Likewise.
> > 	* ld-arm/attr-merge-4.attr: Likewise.
> > 	* ld-arm/attr-merge-6a.s: Likewise.
> > 	* ld-arm/attr-merge-6b.s: Likewise.
> > 	* ld-arm/attr-merge-6.attr: Add Tag_ABI_FP_number_model.
> >
> >
> > Patch in attachment. Testsuite was run without any regression and GCC
> > bootstrapped
> > and its regression test run without regression neither.
> >
> > Is it ok for trunk?
> >
> > Best regards,
> >
> > Thomas
> 
> 
>